Currently, the field type plugin file has the following @todo's added.

    // @todo Add url validation @see \Drupal\link\Plugin\Field\FieldWidget\LinkWidget.
    // @todo Add autocomplete for internal urls @see \Drupal\link\Plugin\Field\FieldWidget\LinkWidget.
    // @todo Figure out why default width and height won't save.

   // @todo: respect the remote image settings here.

These issues should be resolved and @todo should be removed.

Comments

gaurav.kapoor created an issue. See original summary.

gaurav.kapoor’s picture

Issue summary: View changes

  • gaurav.kapoor committed b846063 on 8.x-1.x
    Issue #3253002 by gaurav.kapoor: Work on all @todo mentioned in the...
gaurav.kapoor’s picture

Status: Active » Fixed

These are resolved and not needed anymore.

// @todo Add url validation @see \Drupal\link\Plugin\Field\FieldWidget\LinkWidget.
// @todo Add autocomplete for internal urls @see \Drupal\link\Plugin\Field\FieldWidget\LinkWidget.
// @todo Figure out why default width and height won't save.
// @todo: respect the remote image settings here.

I didn't understand the exact mindset behind adding the @todo for using image style link so I have removed it for now.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.