Problem/Motivation

Issue fork cloud-3252913

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

TamakiFujino created an issue. See original summary.

TamakiFujino opened merge request !547

TamakiFujino’s picture

TamakiFujino commented
Title: Add a BDD test suite for AWS resource: Elastic IPs (1) (Create) » Add a BDD test suite for AWS resource: Elastic IPs
TamakiFujino’s picture

TamakiFujino commented
Status: Active » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

@tamakifujino @kumikoono

Thank you for adding the feature. I posted my comment. Could you please check it?

Also, I think AWS-ATDD-00-05-UserResourceElasticIP.feature filename can be increment e.g. AWS-ATDD-01-01-UserResourceElasticIP.feature

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work
TamakiFujino’s picture

TamakiFujino commented
Status: Needs work » Needs review
kumikoono’s picture

kumikoono commented

@tamakifujino These two scenarios look good to me.
(We know you'll add more scenarios into the same file to cover more operations on the created Elastic IP. ) I found you've filed another issue for this. That's fine.

kumikoono’s picture

kumikoono commented
Status: Needs review » Reviewed & tested by the community
TamakiFujino’s picture

TamakiFujino commented
Status: Reviewed & tested by the community » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Title: Add a BDD test suite for AWS resource: Elastic IPs » Add a BDD test suite for AWS resources (Elastic IPs)
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

@tamakifujino

Thank you for adding scenarios. I have comments but they should be handled by another issue. I'll merge the patch to 4.x and close this issue as Fixed.

  • yas committed 51809e4 on 4.x authored by TamakiFujino 
    Issue #3252913 by TamakiFujino, yas, kumikoono: Add a BDD test suite for...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

yas closed merge request !547