Closed (fixed)
Project:
Drupal core
Version:
9.4.x-dev
Component:
base system
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
3 Dec 2021 at 10:14 UTC
Updated:
8 Feb 2022 at 13:24 UTC
Jump to comment: Most recent
Problem/Motivation
In #3210486: Remove typo3/phar-stream-wrapper and associated code we found out deprecating class \Drupal\Core\Security\PharExtensionInterceptor using the "normal" way as described in the Drupal deprecation policy is a bit "awkward", since it will leave an unused file with unresolved classes lingering around until 11.0.0.
@andypost suggested to mark this class as @internal first in 9.4.0, so we can remove this file altogether in 10.0.0 without doing the "Deprecation Dance".
This issue is here to do just that: Mark class \Drupal\Core\Security\PharExtensionInterceptor as @internal in 9.4.0.
EDIT: As proposed by @longwave in #4 also make clear this class will be deprecated in Drupal 10.0.0
Steps to reproduce
Proposed resolution
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
Class \Drupal\Core\Security\PharExtensionInterceptor is marked as @internal and will be removed from Drupal 10.0.0.
Issue fork drupal-3252406
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #3
spokjeComment #4
longwaveLet's also add a comment that this class will be removed in Drupal 10 and link to the relevant issue?
I also think this can go back to 9.3.x as it's a docs only change.
Comment #5
spokje@longwave in #4: Sense = made :)
Added this as a comment, unsure if this has to be done in the "official" deprecation format. So some eyes on that would be nice.
I _think_ a Change Record is also needed besides a comment, so I created a draft one here. This is also very much open for improvements.
Also updated TR to reflect the intent to deprecate in Drupal 10.0.0.
Comment #6
andypostI think it should be deprecated in 9.4.x and removed in D10
maybe it should use proper deprecation message
Comment #7
spokjeTried to address points raised by @andypost.
Comment #8
spokjeMerged in latest commits from
9.4.x-dev.Comment #9
longwaveComment #10
alexpottThe @todo here really is not necessary - we're stating that the thing is going to be removed in the deprecation. That's duplication. And the link to the issue to do the removal is not all that helpful. Also removing the original @see is wrong too. Fixed on commit.
Committed and pushed ee38989c9cf to 10.0.x and 5ebe32e539a to 9.4.x. Thanks!