List of code standard violations on file, for convenience.
Previous summary only mentioned "t() calls should be avoided in classes" warnings, which are a small percentage of current code standard issues.

CommentFileSizeAuthor
#4 apw_cs_violations.txt28.28 KBjmizarela

Issue fork amazon_product_widget-3252223

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

swatichouhan012 created an issue. See original summary.

miha.wagner’s picture

miha.wagner commented
Assigned: swatichouhan012 » miha.wagner
jmizarela’s picture

jmizarela commented
Assigned: miha.wagner » jmizarela
Category: Feature request » Task

Hey @Miha Wagner, I'm assigning this to myself, as it was open for seven months. Just message me if this was a mistake, and you still wanna work on this issue.

jmizarela’s picture

jmizarela commented
Title: t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead » Code standard issues
Issue summary: View changes
StatusFileSize
new apw_cs_violations.txt28.28 KB
jmizarela’s picture

jmizarela commented
Title: Code standard issues » Drupal coding standards issues

jmizarela opened merge request !4

jmizarela’s picture

jmizarela commented
Assigned: jmizarela » Unassigned
Status: Active » Needs review
christyanpaim’s picture

christyanpaim commented
Assigned: Unassigned » christyanpaim
christyanpaim’s picture

christyanpaim commented
Assigned: christyanpaim » Unassigned
gersonjl’s picture

gersonjl
He/Him
Primary language Portuguese, Brazil
commented
Assigned: Unassigned » gersonjl

Hi, I'll review it.

gersonjl’s picture

gersonjl
He/Him
Primary language Portuguese, Brazil
commented
Status: Needs review » Needs work

Still a lot of errors, moving to "Needs work".

gersonjl’s picture

gersonjl
He/Him
Primary language Portuguese, Brazil
commented
Assigned: gersonjl » Unassigned
Status: Needs work » Reviewed & tested by the community

.

gersonjl’s picture

gersonjl
He/Him
Primary language Portuguese, Brazil
commented
Assigned: Unassigned » gersonjl
Status: Reviewed & tested by the community » Needs review
gersonjl’s picture

gersonjl
He/Him
Primary language Portuguese, Brazil
commented
Assigned: gersonjl » Unassigned
viniciuscosta’s picture

viniciuscosta commented
Assigned: Unassigned » viniciuscosta

I will review it

viniciuscosta’s picture

viniciuscosta commented
Assigned: viniciuscosta » Unassigned
Status: Needs review » Reviewed & tested by the community

I reviewed it here, all the coding standards were solved, I only fixed some errors in README.MD file, so I will move to RTBC. Thanks a lot for the nice work @jmizarela, @christyanpaim, @GersonJL.

miha.wagner’s picture

miha.wagner commented
Status: Reviewed & tested by the community » Fixed

Marked as fixed, merged into 1.5.x, thank you for your contributions, much appreciated.

miha.wagner’s picture

miha.wagner commented
Status: Fixed » Closed (fixed)