Problem/Motivation

As suggested by @heddn in #1835754-46: Add last 'changed' property to user entity, now that D7 has a "changed" property on user entities, D9 should have the ability to include that in migrations from D7.

Steps to reproduce

Do a migration from D7.83 or later.

Proposed resolution

Add the "changed" property to D9's D7 migration code, ensuring that it's optional as older version of D7 will not have it.

Remaining tasks

#2329253: Allow ChangedItem to skip updating the entity's "changed" timestamp when synchronizing
Add the field to \Drupal\user\Plugin\migrate\source\d7\User::fields
Patch, review, commit etc..

User interface changes

?

API changes

n/a

Data model changes

n/a

Release notes snippet

n/a

Issue fork drupal-3252133

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mcdruid created an issue. See original summary.

heddn’s picture

heddn
Primary language English
Location Illinois
commented
Issue tags: +Novice

This is a novice/trivial change. Tagging Novice for the addition of changed. Not the rest of this issue.

All that needs to be done as a first step is add:

changed: changed

to d7_user.yml

After that, we should adjust tests and even the D7 fixture. But getting that first patch rolled with changed added will give us something for folks to use in a patch file when migrating while we get test coverage up to speed.

mauryarahul11’s picture

mauryarahul11
Location Mumbai, India
commented
Assigned: Unassigned » mauryarahul11

mauryarahul11 opened merge request !1571

mauryarahul11 closed merge request !1571

mauryarahul11 opened merge request !1586

mauryarahul11’s picture

mauryarahul11
Location Mumbai, India
commented
Assigned: mauryarahul11 » Unassigned
Status: Active » Needs review
quietone’s picture

quietone commented
Issue tags: -Novice +Needs tests

@mauryarahul11, thanks for starting this off.

This will need changes to the test fixture and tests. Adding tags and removing novice tag.

quietone’s picture

quietone commented
Status: Needs review » Needs work

Oops, need to set this to NW for the next steps.

mauryarahul11’s picture

mauryarahul11
Location Mumbai, India
commented
Assigned: Unassigned » mauryarahul11
mauryarahul11’s picture

mauryarahul11
Location Mumbai, India
commented
Assigned: mauryarahul11 » Unassigned

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

quietone’s picture

quietone commented
Issue tags: +migrate-d7-d8

Just updating tags,

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

quietone’s picture

quietone commented
Issue summary: View changes

Now that the data is in the D7 fixture I went to write the test. I discovered that changed timestampe saved on the destination is the time of the save, not the date in the source. Does this need #3052115: Mark an entity as 'syncing' during a migration update?

quietone’s picture

quietone commented
Status: Needs work » Needs review

Set to NR for the question in #15

heddn’s picture

heddn
Primary language English
Location Illinois
commented
Related issues: +#2329253: Allow ChangedItem to skip updating the entity's "changed" timestamp when synchronizing

I think we need #2329253: Allow ChangedItem to skip updating the entity's "changed" timestamp when synchronizing

quietone’s picture

quietone commented
Issue summary: View changes
Status: Needs review » Postponed

Yes, that looks like the right issue. I am postponing this on the issue mentioned in #17.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

quietone’s picture

quietone commented

The Migrate Drupal Module was approved for removal in #3371229: [Policy] Migrate Drupal and Migrate Drupal UI after Drupal 7 EOL.

This is Postponed. The status is set according to two policies. The Remove a core extension and move it to a contributed project and the Extensions approved for removal policies.

The deprecation work is in #3522602: [meta] Tasks to remove Migrate Drupal module and the removal work in #3522602: [meta] Tasks to remove Migrate Drupal module.

Migrate Drupal will not be moved to a contributed project. It will be removed from core after the Drupal 12.x branch is open.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.

quietone’s picture

quietone commented
Status: Postponed » Closed (won't fix)

The Migrate Drupal Module and Migrate Drupal UI are deprecated and they are not in Drupal 12.0.0.

Issues for these modules should now be on the 11.x branch. And the changes are limited to critical and major bug fixes. Other changes are allowed at the discretion of the core Release Managers in consultation with the Migrate subsystem maintainers.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.