Problem/Motivation

I noticed with multiple instances like 

$this->refreshUpdateStatus([$this->updateProject => "$minor_version.1" . $extra_version]);
        $this->standardTests();
        $this->drupalGet('admin/reports/updates');
        $this->clickLink('Check manually');
        $this->checkForMetaRefresh();

But the last 3 line here already happen in `refreshUpdateStatus()` so they do not need to be called again.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3252067

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

tedbow created an issue. See original summary.

tedbow opened merge request !1462

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Active » Needs work

I am pretty sure there are more instances in core/modules/update/tests/src/Functional that need to be removed

spokje’s picture

spokje
Primary language Dutch
commented
Assigned: Unassigned » spokje

Nice catch, looking at all instances of refreshUpdateStatus() now to find more candidates.

spokje’s picture

spokje
Primary language Dutch
commented
Status: Needs work » Needs review

Note to self: Not every $this->drupalGet() with an URI starting with '/admin/reports/' will be 'admin/reports/updates'...

All green => NR

spokje’s picture

spokje
Primary language Dutch
commented
Assigned: spokje » Unassigned
kunal.sachdev’s picture

kunal.sachdev commented
Status: Needs review » Reviewed & tested by the community

I checked again for this duplicate code, and it's replaced everywhere.

  • catch committed 5e0c689 on 10.0.x 
    Issue #3252067 by tedbow, Spokje: Remove duplicate loading of update...

  • catch committed 2d9eca9 on 9.4.x 
    Issue #3252067 by tedbow, Spokje: Remove duplicate loading of update...
catch’s picture

catch
he/him
Primary language English
commented
Version: 9.4.x-dev » 9.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 10.0.x, cherry-picked to 9.4.x and 9.3.x, thanks!

  • catch committed bf1fc45 on 9.3.x 
    Issue #3252067 by tedbow, Spokje: Remove duplicate loading of update...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.