Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
I noticed with multiple instances like
$this->refreshUpdateStatus([$this->updateProject => "$minor_version.1" . $extra_version]);
$this->standardTests();
$this->drupalGet('admin/reports/updates');
$this->clickLink('Check manually');
$this->checkForMetaRefresh();
But the last 3 line here already happen in `refreshUpdateStatus()` so they do not need to be called again.
Steps to reproduce
Proposed resolution
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
Issue fork drupal-3252067
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
tedbowI am pretty sure there are more instances in
core/modules/update/tests/src/Functional
that need to be removedComment #4
SpokjeNice catch, looking at all instances of
refreshUpdateStatus()
now to find more candidates.Comment #5
SpokjeNote to self: Not every
$this->drupalGet()
with an URI starting with '/admin/reports/' will be 'admin/reports/updates'...All green => NR
Comment #6
SpokjeComment #7
kunal.sachdev CreditAttribution: kunal.sachdev at Acquia commentedI checked again for this duplicate code, and it's replaced everywhere.
Comment #10
catchCommitted/pushed to 10.0.x, cherry-picked to 9.4.x and 9.3.x, thanks!