Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Problem/Motivation
It is hard to follow with the code, when it's not following the Drupal standard and Drupal Practice.
And that will be harder to commit or fix with MR or a patch.
Our eyes are used to read code with Drupal standard.
Remaining tasks
- Get the Module compatible for Drupal 9
- Fix all reported standard points to set the floor clean for more collaborative work
- Testing/Review
- Release
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | 3250574-4.patch | 27.46 KB | Matheus Macario |
Issue fork digitallocker-3250574
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #3
Matheus Macario commentedComment #4
Matheus Macario commentedI did some changes on the module and these were the steps performed :
- Installed module
- Reproduced the phpcs issues that were showing
- fixed all the syntax, coding standards and best practices issues on the module
- Code review the changes, read some documentation related to the issue and the changes applied.
- Tested again and nothing was found.
I couldn't get the module compatible for Drupal 9, i tried but with no success. I'll do some studies and tried again. For now, this patch has all the coding standards issues fixed.