Now that #2730631: Upcast node and node_revision parameters of node revision routes is committed to core, deleting a revision via the revision overview no longer works in Drupal 9.3. The following error is shown:
Error: Object of class Drupal\node\Entity\Node could not be converted to string in Drupal\Core\Entity\EntityStorageBase->buildCacheId() (line 126 of core/lib/Drupal/Core/Entity/EntityStorageBase.php).
Go to the revision overview and try to delete a revision.
For now we should probably harden the code to allow more flexibility when deleting a revision.
-
-
-
| Comment | File | Size | Author |
|---|---|---|---|
| #11 | 3249493-11.patch | 1.78 KB | eric_a |
| #11 | interdiff-3249493_5-11.txt | 691 bytes | eric_a |
| #9 | 3249493-9.patch | 1.65 KB | gaards |
| #2 | 3249493-2.patch | 1.81 KB | seanb |
Comments
Comment #2
seanbPatch is attached.
Comment #3
adriancidHi @seanB thanks for the issue and for the patch, I think is better to just add a restriction for the Drupal >= 9.3 in the module and use the new way, what do you think?
Comment #4
seanbI thought about that, but there will be a transition period where it is perfectly fine to run either 9.2 or 9.3. Since supporting both versions is relatively easy, I would personally lean towards a (temporary) solution that supports both, and remove the extra code when 9.2 is deprecated. We could probably already create a followup issue and a MR and just postpone that issue for now.
Comment #5
eric_a commentedIMHO the simplest way to stay compatible with both <9.3 and ^9.3 in this case is leveraging
RouteMatchInterface::getRawParameter(). Also, this way the "get ID from URL" comment remains accurate.Comment #6
dunebl#5 is doing the job... many thanks!
Comment #7
jjancel commentedHello
here we go again new drupal revision 9.3.3 same error
when the correction will be integrated into the module
Comment #8
3cwebdev commentedPatch #5 works on D9.3.3.
Comment #9
gaards commentedPatch #5 doesn't apply to the current latest release 8.x-1.0-rc3 as the dev version has some changes around the same lines. I added a patch for those that need a patch compatible with 8.x-1.0-rc3.
Comment #10
jmoruziPatch #9 works on 8.x-1.0-rc3 on D9.3.7. Thanks.
Comment #11
eric_a commentedLooking at the differences between #5 and the backport to 8.x-1.0-rc3 I suddenly realised that I had not removed the @todo comment.
Here's an update of #5, now with the removal of the @todo comment.
It won't apply to 8.x-1.0-rc3. Just use #9 for patching 8.x-1.0-rc3. (Thanks, @gaards!)
Comment #12
michelle-buckby commentedPatch #9 working great for my needs with 8.x-1.0-rc3
Comment #13
adriancidThanks
Comment #15
subir_ghoshPatch #9 works. D 9.3.9 + 8.x-1.0-rc3