Problem/Motivation

Zero values in CSS should not contain a unit declaration per formatting guidelines. Zero value unit is present in `diff.general.css` on L10.

Proposed resolution

Remove the unit attached to zero value is stylesheet and save a byte. I will provide a patch.

CommentFileSizeAuthor
#2 diff-zero-value-unit-3248790-2.patch283 bytesbygeoffthompson

Issue fork diff-3248790

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

bygeoffthompson created an issue. See original summary.

bygeoffthompson’s picture

bygeoffthompson commented
Assigned: bygeoffthompson » Unassigned
Status: Active » Needs review
StatusFileSize
new diff-zero-value-unit-3248790-2.patch283 bytes

silvi.addweb made their first commit to this issue’s fork.

silvi.addweb opened merge request !55

silvi.addweb’s picture

silvi.addweb commented
Status: Needs review » Reviewed & tested by the community

I've tested and raised MR.

acbramley’s picture

acbramley commented
Status: Reviewed & tested by the community » Needs work

Please ensure you do not use the 8.x-1.x in the fork and push work to the proper branch.

acbramley’s picture

acbramley commented
Version: 8.x-1.x-dev » 2.x-dev

Development must be done against 2.x

Indranil Roy made their first commit to this issue’s fork.

Indranil Roy opened merge request !86

indranil roy’s picture

indranil roy commented

Hey @acbramley,
I have raised the MR changed the targeted branch 2.x. please review.

indranil roy’s picture

indranil roy commented
Assigned: Unassigned » indranil roy
Status: Needs work » Needs review
acbramley’s picture

acbramley commented
Title: Drupal CSS Standards (zero value units) » Fix stylelint warnings
Status: Needs review » Needs work

I don't really see the point in fixing 1 failure in stylelint. I'd rather see it all fixed at once.

heddn made their first commit to this issue’s fork.

heddn’s picture

heddn
Primary language English
Location Illinois
commented
Title: Fix stylelint warnings » Fix stylelint & eslint warnings
lavanyatalwar’s picture

lavanyatalwar commented
Status: Needs work » Reviewed & tested by the community

Hi @lucashedding
Thank you for updating the MR. Pipeline is green for stylelint and eslint now.
Moving it to RTBC+

heddn’s picture

heddn
Primary language English
Location Illinois
commented
Title: Fix stylelint & eslint warnings » Fix stylelint & eslint & php code standard warnings

heddn’s picture

heddn
Primary language English
Location Illinois
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.