With the config schema validator service enabled (eg. in a local development environment), enabling the module yields an error:
Schema errors for node_read_time.settings with the following errors: node_read_time.settings:reading_time missing schema
By only fixing this, we'll get 2 other errors:
Schema errors for node_read_time.settings with the following errors: node_read_time.settings:reading_time.container missing schema, node_read_time.settings:reading_time.words_per_minute variable type is string but
applied schema class is Drupal\Core\TypedData\Plugin\DataType\IntegerDataSee above.
Fix the config schema.
Review, commit, release.
None.
None.
None.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | fix-config-schema-errors-3248670-4.patch | 2.28 KB | attila.fekete |
| #3 | fix-config-schema-errors-3248670-3.patch | 860 bytes | attila.fekete |
Comments
Comment #2
attila.fekete commentedComment #3
attila.fekete commentedComment #4
attila.fekete commentedIgnore patch #3, this needed more changes.
Since the schema was incorrect, $form_state->getValues() (inside submitForm()) was saving unneeded form array data like form_build_id, form_token, form_id, etc. which we shouldn't store in the configuration.
Patch #4 also fixes this.
Comment #5
attila.fekete commentedAccidentally uploaded patch #4 twice.
Comment #6
attila.fekete commentedComment #7
morvaim commentedLooks good to me.
Comment #8
yivanov commentedThanks for the fix! Do you consider it as a breaking change for old installations of the module as the schema is different? Perhaps it needs update hook as well?
Comment #10
yivanov commented