Closed (fixed)
Project:
Facets Form
Version:
1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
8 Nov 2021 at 12:26 UTC
Updated:
2 Dec 2025 at 14:44 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #4
julien tekrane commentedComment #5
vensiresIt's been a year I am using the patch in various projects so - now that we have a stable release - it's time I set it as RTBC.
Comment #6
julien tekrane commentedDear @vensires, thank you for your appreciation but my PR does not contain tests so the maintainers will not merge it. I don't have dedicated time to implement it, I leave the floor to whoever wants it
Comment #7
vensiresThank you for your effort nevertheless!
I will keep it as RTBC until the maintainers decide otherwise. For now, I just add the tag "Needs tests".
Comment #8
carolpettirossi commentedI'm using the MR code along with an Aggregate Fulltext field successfully
Thank you so much for contributing =D
Comment #9
vensiresFor a website of ours, I use this fulltext facet filter to search for keywords. The client asked that whether user searches for "foo bar" or "bar foo" the returned result should be the same. I tried playing around tampering the query using proper Search API Events but instead fell back on changing the original patch from this issue's MR (attached) so that the 'LIKE' operator uses multiple conditions instead using AND.
I'm sharing this here too in case we would like a different approach for this or propose a different operator... Maybe...
Comment #10
vensiresComment #11
julien tekrane commentedDear maintainers,
I implemented tests. Pipeline is red due to extra config of the project. Can you please approve and embed it in the next Release ?
Comment #12
andras_szilagyi commentedI'm adding a patch with the current state in case anybody is relying on the MR as a patch
Comment #13
andras_szilagyi commentedGenerally speaking looks good, just needs a fix and a few minor improvements.
Comment #14
andras_szilagyi commentedAlso tests are red
Comment #15
willsstrong commentedPatch won't apply on v1.2.0. There seems to be a mismatch with the README.md file.
Comment #16
willsstrong commentedThis patch works with v1.2.0. The only difference is that no changes are made to the README.md file.
Comment #17
julien tekrane commentedComment #18
andras_szilagyi commentedI had to fix the schema and added some testing. Regarding testing the "Like" operator was not working out of the box. I had to remove the Like for now as I was contacted with the urgency of this issue and want to move on, so @vensires please open up a follow up please.
Comment #19
andras_szilagyi commentedFor anyone needing the "Like" till then, please see https://www.drupal.org/project/search_api/issues/3033665
Comment #20
andras_szilagyi commentedI merge, there was a pipeline error during the merge due to a HTTP 500 error
"Error: Server answered with HTTP 500 when performing the request to https://repo.yarnpkg.com/4.9.1/packages/yarnpkg-cli/bin/yarn.js"
seems unrelated so I'm closing this issue as Fixed