Problem/Motivation

Need tests for group discount, group item discount, bundle discount field, and include parent.

Proposed resolution

Get it done.

CommentFileSizeAuthor
#12 interdiff_11-12.txt4.37 KBtonytheferg
#12 discount_test-3248103-12.patch15.4 KBtonytheferg
#11 interdiff_10-11.txt5 KBtonytheferg
#11 discount_test-3248103-11.patch15.94 KBtonytheferg
#10 interdiff_7-10.txt606 bytestonytheferg
#10 discount_test-3248103-10.patch17.45 KBtonytheferg
#7 discount_test-3248103-7.patch17.32 KBtonytheferg
#5 discount_test-3248103-5.patch17.33 KBtonytheferg
#4 bundle_discount_test-3248103-4.patch8.8 KBtonytheferg
#3 bundle_discount_test-3248103-3.patch9.82 KBtonytheferg
#2 bundle_discount_test-3248103-2.patch10.71 KBtonytheferg

Comments

tonytheferg created an issue. See original summary.

tonytheferg’s picture

tonytheferg commented
Title: create test for bundle discount field » create test for bundle discount field and include parent.
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new bundle_discount_test-3248103-2.patch10.71 KB
tonytheferg’s picture

tonytheferg commented
StatusFileSize
new bundle_discount_test-3248103-3.patch9.82 KB

Ok, I commited the strpos fix in the original bug report, and rerolled the patch.

tonytheferg’s picture

tonytheferg commented
StatusFileSize
new bundle_discount_test-3248103-4.patch8.8 KB

Moving product and variation creation into setup so that it doesn't need to be repeated.

tonytheferg’s picture

tonytheferg commented
Title: create test for bundle discount field and include parent. » create discount test.
StatusFileSize
new discount_test-3248103-5.patch17.33 KB

I rewrote this test to include the whole discount tree. No interdiff will be provided as it is a complete rewrite.

tonytheferg’s picture

tonytheferg commented
Issue summary: View changes
tonytheferg’s picture

tonytheferg commented
StatusFileSize
new discount_test-3248103-7.patch17.32 KB

File name was wrong.

tonytheferg’s picture

tonytheferg commented
Status: Needs review » Closed (outdated)

Rolling this test into flat discount issue for now.

tonytheferg’s picture

tonytheferg commented
Status: Closed (outdated) » Postponed

Setting this to postponed because I'm not sure when the other issue will land.

tonytheferg’s picture

tonytheferg commented
Status: Postponed » Needs review
StatusFileSize
new discount_test-3248103-10.patch17.45 KB
new interdiff_7-10.txt606 bytes
tonytheferg’s picture

tonytheferg commented
StatusFileSize
new discount_test-3248103-11.patch15.94 KB
new interdiff_10-11.txt5 KB

This patch trims some of the fat from the product creation using the traits.

tonytheferg’s picture

tonytheferg commented
StatusFileSize
new discount_test-3248103-12.patch15.4 KB
new interdiff_11-12.txt4.37 KB

A little more clean up.

  • tonytheferg committed 6563e2a on 2.0.x 
    Issue #3248103 by tonytheferg: create discount test
tonytheferg’s picture

tonytheferg commented
Status: Needs review » Fixed
tonytheferg’s picture

tonytheferg commented
Status: Fixed » Closed (fixed)