Because of #3083275: [meta] Update tests that rely on Classy to not rely on it anymore and Classy being deprecated in Drupal 9 + removed in Drupal 10,: Tests that aren't specifically testing Classy yet declare $defaultTheme = 'classy'; should be refactored to use Stark as the default theme instead.
Update ContentTranslationUITestBase and all classes that extend this class to use Stark as the default theme, and refactor the tests where needed so they continue to function properly.
The tests that extend ContentTranslationUITestBase are:
MenuLinkContentTranslationUITest in menu_link_content.moduleBlockContentTranslationUITest in block_content.moduleCommentTranslationUITest in comment.module(already uses stark)
ContentTestTranslationUITest in content_translation.moduleMediaTranslationUITest in media.moduleNodeTranslationUITest in node.module(already uses stark)
ShortcutTranslationUITest in shortcut.moduleTermTranslationUITest in taxonomy.moduleUserTranslationUITest in user.module| Comment | File | Size | Author |
|---|---|---|---|
| #3 | 3247901-3.patch | 5.29 KB | danflanagan8 |
Comments
Comment #2
danflanagan8Comment #3
danflanagan8This turned out to be really easy. There was only a single change required in the base class and then all the other classes passed with stark.
I also did a check that there weren't any negative assertions that would possibly get messed up moving from classy to stark. That's something that will be harder to catch in issues like this I think.
Comment #4
longwaveThis looks OK to me.
Comment #7
catchCommitted/pushed to 9.4.x and cherry-picked to 9.3.x, thanks!