Plausible allows your site to be tracked using Plausible, a simple and privacy-friendly alternative to Google Analytics. It does this by adding a Javascript tracking snippet to the site's webpages.

Project link

https://www.drupal.org/project/plausible

Git instructions

git clone https://git.drupalcode.org/project/plausible.git

Comments

DieterHolvoet created an issue. See original summary.

avpaderno’s picture

Issue summary: View changes
Status: Needs review » Needs work
  • What follows is a quick review of the project; it doesn't mean to be complete
  • For every point, the review doesn't make a complete list of lines that should be fixed, but an example of what is wrong in the code
  • A review is about code that doesn't follow the coding standards, contains possible security issue, or doesn't correctly use the Drupal API; if a point isn't about that, it makes it clear
    $intro_message = $this->t('Visit @plausibleWebsite to sign up for a free account.', [
      '@plausibleWebsite' => Markup::create('<a href="https://plausible.io" target="_blank">Plausible.io</a>'),
    ]);

Markup is an internal class that modules that aren't part of Drupal core should not use. It's marked internal because it doesn't output safe markup. In the case of a link added in a translatable string, it's not even necessary to use it. path_help() shows how links are added to translatable strings.

dieterholvoet’s picture

dieterholvoet’s picture

Status: Needs work » Needs review
avpaderno’s picture

Assigned: Unassigned » avpaderno
Status: Needs review » Fixed

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.