Problem/Motivation

VendorStreamWrapperService::creatUrlFromUri() returns wrong URL if Drupal is installed in a subdirectory, the subdirectory appears twice, like

http://192.168.1.2/d91/d91/vendor_files/jaypan/jquery-colorpicker/js/colorpicker.js?v=1.0.1

here d91 is the root subdirectory and you can see it appears twice.

Steps to reproduce

Install Drupal in a subdirectory and try to use the jquery colorpicker widget.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork vendor_stream_wrapper-3247505

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mondrake created an issue. See original summary.

mondrake opened merge request !2

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Active » Needs review

The MR seems to fix this. It's due to re-adding the base url to css and js URLs. Added an option to the functions to remove the base URL.

Jaypan made their first commit to this issue’s fork.

  • Jaypan committed 93466ea on 8.x-1.x authored by mondrake 
    Issue #3247505: VendorStreamWrapperService::creatUrlFromUri() returns...
jaypan’s picture

jaypan
Location Victoria, BC
commented
Status: Needs review » Fixed

Thank you, this will be part of the next release.

mondrake’s picture

mondrake
Location 🇮🇹
commented

Thanks. it would be good to have a new release of the jquery_colorpicker module using this, #3253237: Bump drupal/vendor_stream_wrapper to ^2 in composer.json.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.