On line 457:
if (data.messages) {

Does not always return true when 'messages' is a string, causing a blank lightbox to be displayed instead of the value of messages. For an example, enable popups on the signup form (I will provide a module to enable this in the coming days - my first ever module!)

if (data.messages.length > 0) { will return the desired result

Line 492 is also afflicted, replace with:

if (!data.messages.length) {

Comments

lowkee’s picture

lowkee commented
Version: 6.x-1.1-beta5 » 6.x-1.1-rc1

Bug still active as of RC1

starbow’s picture

starbow commented
Assigned: Unassigned » starbow
Status: Needs review » Fixed

Thanks.
I was just realizing that javascript doesn't consider a string to be true. I got spoiled by perl/php.
This will be fixed in RC2.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.