This is a regression from #3186992: Nav menu items can overflow outside of container

The dropdowns and hover states should have more bottom visual spacing

CommentFileSizeAuthor
#2 After-patch.png500.05 KBSakthivel M
#2 before-patch.png561.26 KBSakthivel M
#2 Olivero:Alignment-of-primary-menu-hover-states-and-dropdowns-is-incorrect-at-wide-widths-3247269-2.patch1.19 KBSakthivel M
correct.png182.8 KBmherchel
broken.png206.88 KBmherchel
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mherchel created an issue. See original summary.

Sakthivel M’s picture

Sakthivel M CreditAttribution: Sakthivel M at QED42 for Drupal India Association commented
Status: Active » Needs review
FileSize
Olivero:Alignment-of-primary-menu-hover-states-and-dropdowns-is-incorrect-at-wide-widths-3247269-2.patch1.19 KB
before-patch.png561.26 KB
After-patch.png500.05 KB

#2 Please review the patch

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
CreditAttribution: mherchel at Lullabot commented
Status: Needs review » Reviewed & tested by the community

#2 looks perfect. Thanks @Sakthivel M

  • lauriii committed b8c9366 on 9.4.x 
    Issue #3247269 by Sakthivel M, mherchel: Olivero: Alignment of primary...
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
CreditAttribution: lauriii at Acquia commented
Version: 9.4.x-dev » 9.3.x-dev

Committed b8c9366 and pushed to 9.4.x. Thanks!

Leaving open for 9.3.x backport.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

  • lauriii committed 678734f on 9.3.x 
    Issue #3247269 by Sakthivel M, mherchel: Olivero: Alignment of primary...
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
CreditAttribution: lauriii at Acquia commented
Status: Reviewed & tested by the community » Fixed

Got a +1 from @alexpott and @catch on Slack. Cherry-picked and pushed to 9.3.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.