Closed (fixed)
Project:
Social Base
Version:
2.1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
29 Oct 2021 at 09:35 UTC
Updated:
9 Dec 2021 at 06:19 UTC
Jump to comment: Most recent, Most recent file
Problem/Motivation
In https://github.com/goalgorilla/open_social/pull/2478 we're improving how we use the theme system and Field API for Open Social profiles. This means that we need to update some of our theme files to work with the new render method.
Steps to reproduce
Proposed resolution
A new twig file is needed to add back the card and a new way to render fields is needed to mimic the current layout. This is done with a new hook suggestion so that profile field display in teasers and the hero can be left undisturbed and updated at a later date.
These changes are backwards compatible with Open Social 10.x and 11.0.0 since the current implementation renders a view that does not use the full display mode for which we are adding files and code.
Remaining tasks
User interface changes
API changes
Data model changes
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | socialbase-3246580-3-profile-theme-updates.patch | 4.86 KB | kingdutch |
Comments
Comment #2
kingdutchA patch for testing until it's safe to merge this.
Merging this patch before Open Social 12.0.0 would probably cause the existing profile display to break, so this may need a socialbase 3.0.0 release.
Comment #3
kingdutchBackwards compatibility was tested in https://github.com/goalgorilla/open_social/pull/2572 and the changes are backwards compatible with earlier versions of Open Social.
This updated patch adds a small bugfix that was discovered in the ThemeSuggestionsAlter class.
Comment #4
navneet0693 commentedComment #5
navneet0693 commentedThis will be available in Socialbase 2.1.x onwards.s