As per #2868876: Remove deprecated entitymanager and db_select, the database connection should be injected rather than making a static call to the database service.

CommentFileSizeAuthor
#3 auto_index-inject-database-3246314-2.patch2.43 KBjohnpitcairn

Comments

John Pitcairn created an issue. See original summary.

John Pitcairn credited ushma.

johnpitcairn’s picture

johnpitcairn commented
Status: Active » Needs review
StatusFileSize
new auto_index-inject-database-3246314-2.patch2.43 KB

The solution proposed by @ushma in #2868876: Remove deprecated entitymanager and db_select is:

$query = $this->database->select('node', 'n', array('target' => 'replica'));

This works in that indexing completes, but throws a warning:

Warning: assert(): Passing "target" option to query() has no effect.

I think $this->databaseReplica should be used to query the database replica.

johnpitcairn’s picture

johnpitcairn commented

Yup. See #3001216: Use the database.replica service where appropriate. Let's just commit this.

  • John Pitcairn authored fcfde34 on 8.x-1.x 
    Issue #3246314 by John Pitcairn, ushma: Inject the database connection
johnpitcairn’s picture

johnpitcairn commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.