Problem/Motivation

Taxonomy Term has the field_ui_base_route set to entity.taxonomy_vocabulary.overview_form, in taxonomy.links.tasks.yml the base route for both the List and Edit tabs is also the overview_form route, this all makes sense.

Yet in #2934995: Add a "Manage permissions" tab for each bundle that has associated permissions we noted that the route paths are not consistent with this, to quote @benjifisher in #mr1296-note51248:

I think it is pretty odd to use the path /admin/structure/taxonomy/manage/tags/overview/permissions instead of /admin/structure/taxonomy/manage/tags/permissions, but that is consistent with what the field_ui gives us.

The oddness also affects the breadcrumbs.

Maybe we should update the taxonomy module to use /admin/structure/taxonomy/manage/tags for the overview page and /admin/structure/taxonomy/manage/tags/edit for the edit form.

The links section of the taxonomy_vocabulary Entity Type shows:

 *     "overview-form" = "/admin/structure/taxonomy/manage/{taxonomy_vocabulary}/overview",
 *     "edit-form" = "/admin/structure/taxonomy/manage/{taxonomy_vocabulary}",

As noted above, this results in some oddities with generated paths and breadcrumbs, this is also not consistent with other core entity types.

Steps to reproduce

Proposed resolution

Update the taxonomy_vocabulary Entity Type links to be:

 *     "overview-form" = "/admin/structure/taxonomy/manage/{taxonomy_vocabulary}",
 *     "edit-form" = "/admin/structure/taxonomy/manage/{taxonomy_vocabulary}/edit",

This will also likely require some BC-layer if we do this in 9.3/9.4, but perhaps we can get away with doing this only in 10.0, as it would be a pretty awkward BC-layer for such a small code change (impact on tests TBC).

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Comments

AaronMcHale created an issue. See original summary.

aaronmchale’s picture

aaronmchale
Primary language English
Location Edinburgh, Scotland
commented
Title: Change Vocabulary overview-form path to be more consistent with other core entity types » Change Vocabulary overview-form and edit-form paths to be more consistent with other core entity types and improve the information architecture
aaronmchale’s picture

aaronmchale
Primary language English
Location Edinburgh, Scotland
commented
Issue summary: View changes

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.