Problem/Motivation

Composer normalize on file: ./scripts/../app/modules/custom/entity_share_websub/composer.json
Composer is operating slower than normal because you have Xdebug enabled. See https://getcomposer.org/xdebug
Running ergebnis/composer-normalize 2.15.0 by Andreas Möller and contributors.

./composer.json is not normalized.

---------- begin diff ----------
--- original
+++ normalized
@@ -1,11 +1,12 @@
 {
     "name": "drupal/entity_share_websub",
+    "type": "drupal-module",
     "description": "A set of modules to enable a variation of the WebSub protocol for Drupal 8 Entity Share module.",
-    "type": "drupal-module",
-    "keywords": ["Drupal"],
+    "keywords": [
+        "Drupal"
+    ],
+    "homepage": "https://www.drupal.org/project/entity_share_websub",
     "license": "GPL-2.0+",
-    "homepage": "https://www.drupal.org/project/entity_share_websub",
-    "minimum-stability": "dev",
     "authors": [
         {
             "name": "Shawn Duncan (FatherShawn)",
@@ -23,12 +24,13 @@
             "role": "Co-maintainer"
         }
     ],
+    "require": {
+        "drupal/entity_share": "^3.0@beta",
+        "drupal/views_custom_cache_tag": "^1.2"
+    },
+    "minimum-stability": "dev",
     "support": {
         "issues": "https://www.drupal.org/project/issues/entity_share_websub",
         "source": "https://git.drupalcode.org/project/entity_share_websub"
-    },
-    "require": {
-        "drupal/entity_share": "^3.0@beta",
-        "drupal/views_custom_cache_tag": "^1.2"
     }
 }

----------- end diff -----------

Composer normalize failed on file: ./scripts/../app/modules/custom/entity_share_websub/composer.json

Also license should be:

    "license": "GPL-2.0-or-later",
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

Grimreaper created an issue. See original summary.

grimreaper’s picture

Assigned: grimreaper » Unassigned
Status: Active » Needs review
fathershawn’s picture

Assigned: Unassigned » perelesnyk

Tidiness is a nice thing!

grimreaper’s picture

Hello maintainers ;)

I made a bunch of issues including this one:
- #3243294: Fix PHPCS
- #3243345: Fix spellcheck
- #3243340: Fix Rector
- #3243356: Fix PHPMD

To start familiarizing more with Entity Share Websub codebase and fixing my CI.

I soon will no more have time available... That's why I made some code cleanup issues.

If I will have the occasion I would like to rework some parts in depth to allow the module to work with any kind of entities #3240108: Add support for entity-types other than nodes.

Maybe in a dedicated branch? But as I do not have the availability now, I prefer not starting this kind of work.

Best regards :)

fathershawn’s picture

Assigned: perelesnyk » fathershawn

fathershawn’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.