Problem/Motivation

Running "phpcs" on core for PHP 8.1 throws a lot of deprecations but there's new release which fixes it (mostly)

@alexpott suggests to wait for behat updates but this issue will help to detect regressions

Steps to reproduce

$ vendor/bin/phpcs core/ --runtime-set installed_paths vendor/drupal/coder/coder_sniffer --standard="core/phpcs.xml.dist" -wsp --colors
...
.................................................            12229 / 12229 (100%)


PHP Deprecated:  Implicit conversion from float 235309.85403060913 to int loses precision in /var/www/html/web/vendor/squizlabs/php_codesniffer/src/Util/Timing.php on line 67

Deprecated: Implicit conversion from float 235309.85403060913 to int loses precision in /var/www/html/web/vendor/squizlabs/php_codesniffer/src/Util/Timing.php on line 67
Time: 3 mins, 55.31 secs; Memory: 158MB

Proposed resolution

COMPOSER_ROOT_VERSION=9.3.x-dev composer update --with=phpunit/phpunit:^8 -W

Remaining tasks

- check for regressions
- look for coder updates
- review/commit

User interface changes

no

API changes

no

Data model changes

no

Release notes snippet

~/.composer/vendor/bin/composer-lock-diff --no-links
+---------------------+-------+-------+
| Production Changes  | From  | To    |
+---------------------+-------+-------+
| guzzlehttp/promises | 1.4.1 | 1.5.0 |
| guzzlehttp/psr7     | 1.8.2 | 1.8.3 |
+---------------------+-------+-------+

+-----------------------------+--------+--------+
| Dev Changes                 | From   | To     |
+-----------------------------+--------+--------+
| behat/mink                  | v1.8.1 | v1.9.0 |
| behat/mink-selenium2-driver | v1.4.0 | v1.5.0 |
| composer/ca-bundle          | 1.2.10 | 1.2.11 |
| composer/composer           | 2.1.8  | 2.1.9  |
| phpdocumentor/type-resolver | 1.5.0  | 1.5.1  |
| squizlabs/php_codesniffer   | 3.6.0  | 3.6.1  |
+-----------------------------+--------+--------+
CommentFileSizeAuthor
#6 3242889-6.patch19.5 KBalexpott
#2 3242889-2.patch2.08 KBandypost

Comments

andypost created an issue. See original summary.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Active » Needs review
StatusFileSize
new 3242889-2.patch2.08 KB
andypost’s picture

andypost
he/him
Primary language Russian
commented

reported upstream https://github.com/squizlabs/PHP_CodeSniffer/issues/3182#issuecomment-94...

- https://github.com/squizlabs/PHP_CodeSniffer/issues/3448
- https://3v4l.org/flZrS

$t=152815.288066864; 
var_dump(((int)$t % 60000));
var_dump(($t % 60000));
daffie’s picture

daffie commented
Status: Needs review » Reviewed & tested by the community

Looks good to me.

The problem has been fixed in https://github.com/squizlabs/PHP_CodeSniffer/pull/3394 which is part of https://github.com/squizlabs/PHP_CodeSniffer/releases/tag/3.6.1.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Title: Upgrade squizlabs/php_codesniffer to 3.6.1 » Update dependencies for 9.3.x
Status: Reviewed & tested by the community » Needs work

Let's wait for the MinkSelenium2Driver release. It will happen soon and this does not buy us that much. Plus it would be great if https://github.com/squizlabs/PHP_CodeSniffer/issues/3448 landed and was released.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Issue summary: View changes
Status: Needs work » Needs review
StatusFileSize
new 3242889-6.patch19.5 KB

Okay the real dependencies blocking us from PHP 8.1 testing have been released - yay. Let's get this one done and profit.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Reviewed & tested by the community

Great news! Patch looks good to me, RTBC if bot agrees.

andypost’s picture

andypost
he/him
Primary language Russian
commented

https://github.com/squizlabs/PHP_CodeSniffer/issues/3448 is approved, please comment there to try speed-up new release

  • catch committed dd2e7b8 on 9.3.x 
    Issue #3242889 by andypost, alexpott: Update dependencies for 9.3.x
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed dd2e7b8 and pushed to 9.3.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.