Problem/Motivation

Steps to reproduce

Open pull form and import entities with translations.
Open again same form with non-default language.
Check the (View local) link - it directed to default language - not that in the same as in channel-language filter.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#3 entity_share-3241601-wrong-view-local.patch1 KBsteus

Comments

steus created an issue. See original summary.

steus’s picture

steus commented
Issue summary: View changes
steus’s picture

steus commented
StatusFileSize
new entity_share-3241601-wrong-view-local.patch1 KB

Here is a fix

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Status: Active » Needs review
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: Unassigned » grimreaper
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Status: Needs review » Reviewed & tested by the community

Nice catch!

+++ b/modules/entity_share_client/src/Service/StateInformation.php
@@ -114,10 +114,10 @@ public function getStatusInfo(array $data) {
+            if ($this->entityHasChanged($existing_entity, $entity_changed_time)) {

I prefer to replace $existing_entity by $existing_translation in the if.

I will commit with my proposed changed.

Thanks!

  • steus authored c912efc on 8.x-3.x 
    Issue #3241601 by steus, Grimreaper: Wrong (View local) link to...
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: grimreaper » Unassigned
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.