Modules property must be declared protected.

The Drupal\Tests\entity\Functional\%ClassTest::$modules property must be declared protected. See https://www.drupal.org/node/2909426

protected $modules is something that was true even in Drupal 7. That should be done, but as you found out from the test results core Drupal still does this wrong in D8. Again, can't be entirely fixed in Entity API until D8 is no longer supported

CommentFileSizeAuthor
#5 3241534-5-protected-static-modules.patch6.85 KBtr
#2 3241534-2.patch6.34 KBaardwolf

Comments

AardWolf created an issue. See original summary.

aardwolf’s picture

aardwolf commented
StatusFileSize
new 3241534-2.patch6.34 KB
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Title: Modules property must be declared protected » $modules property must be declared protected
Status: Active » Needs review
tr’s picture

tr commented
Status: Needs review » Reviewed & tested by the community

D8 support ends on 2 Nov 21, so we should wait until then to commit this.

tr’s picture

tr commented
StatusFileSize
new 3241534-5-protected-static-modules.patch6.85 KB

Here's a re-roll that also uses @inheritdoc consistently for all the protected static $modules declarations.

tr’s picture

tr commented

Note, this can be committed now, because D8 is no longer supported.

  • TR committed e744004 on 8.x-1.x 
    Issue #3241534 by AardWolf, TR: $modules property must be declared...
tr’s picture

tr commented
Status: Reviewed & tested by the community » Fixed

Committed #5.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.