Problem/Motivation

template_preprocess_locale_translation_last_check() passing NULL when no check is done (first run) to \Drupal\Core\Datetime\DateFormatterInterface::formatTimeDiffSince() - the cause of deprecation on PHP 8.1.

Steps to reproduce

Run core/modules/locale/tests/src/Functional/LocaleUpdateInterfaceTest.php on PHP 8.1

Exception : Deprecated function: DateTime::setTimestamp(): Passing null to parameter #1 ($timestamp) of type int is deprecated
Drupal\Core\Datetime\DateFormatter->formatDiff()() (Line: 220)

Proposed resolution

Don't call formatTimeDiffSince() with NULL last check

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#2 3240958-2.patch864 bytesandypost

Comments

andypost created an issue. See original summary.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Active » Needs review
StatusFileSize
new 3240958-2.patch864 bytes

patch from https://git.drupalcode.org/project/drupal/-/merge_requests/937/diffs?com...

andypost’s picture

andypost
he/him
Primary language Russian
commented

The template core/modules/locale/templates/locale-translation-last-check.html.twig using to check the same variable so "never" is displayed from there

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

I wrote this fix as part of #3220021: [meta] Ensure compatibility of Drupal 9 with PHP 8.1 (as it evolves)

daffie’s picture

daffie commented
Status: Needs review » Reviewed & tested by the community

Looks good to me.

  • catch committed c30ae86 on 9.3.x 
    Issue #3240958 by andypost, alexpott:...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed c30ae86 and pushed to 9.3.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.