Problem/Motivation

There are some CS violations:

FILE: ...ml/web/modules/contrib/cloudflare_stream_sync/src/SyncVideos.php
----------------------------------------------------------------------
FOUND 18 ERRORS AFFECTING 17 LINES
----------------------------------------------------------------------
  61 | ERROR | [x] Missing function doc comment
  63 | ERROR | [x] Inline comments must end in full-stops,
     |       |     exclamation marks, question marks, colons, or
     |       |     closing parentheses
  87 | ERROR | [x] Expected 1 space after FOREACH keyword; 0 found
 101 | ERROR | [x] No space found before comment text; expected "//
     |       |     videoID." but found "//videoID."
 105 | ERROR | [x] No space found before comment text; expected "//
     |       |     filename." but found "//filename."
 107 | ERROR | [x] Inline comments must end in full-stops,
     |       |     exclamation marks, question marks, colons, or
     |       |     closing parentheses
 110 | ERROR | [x] Inline comments must end in full-stops,
     |       |     exclamation marks, question marks, colons, or
     |       |     closing parentheses
 125 | ERROR | [x] Inline comments must end in full-stops,
     |       |     exclamation marks, question marks, colons, or
     |       |     closing parentheses
 141 | ERROR | [x] Doc comment short description must end with a full
     |       |     stop
 161 | ERROR | [x] Doc comment short description must end with a full
     |       |     stop
 169 | ERROR | [x] Inline comments must end in full-stops,
     |       |     exclamation marks, question marks, colons, or
     |       |     closing parentheses
 193 | ERROR | [x] Missing function doc comment
 197 | ERROR | [x] Missing function doc comment
 197 | ERROR | [ ] Private method name "SyncVideos::getVideoID" is
     |       |     not in lowerCamel format
 201 | ERROR | [x] Missing function doc comment
 208 | ERROR | [ ] Private method name
     |       |     "SyncVideos::checkIfVideoIDExists" is not in
     |       |     lowerCamel format
 220 | ERROR | [x] Expected 1 blank line after function; 0 found
 221 | ERROR | [x] The closing brace for the class must have an empty
     |       |     line before it


FILE: ...s/contrib/cloudflare_stream_sync/src/Form/SyncVideosSettings.php
----------------------------------------------------------------------
FOUND 1 ERROR AND 2 WARNINGS AFFECTING 3 LINES
----------------------------------------------------------------------
  13 | WARNING | [ ] Line exceeds 80 characters; contains 81
     |         |     characters
  75 | WARNING | [ ] t() calls should be avoided in classes, use
     |         |     \Drupal\Core\StringTranslation\StringTranslationTrait
     |         |     and $this->t() instead
 109 | ERROR   | [x] Inline comments must end in full-stops,
     |         |     exclamation marks, question marks, colons, or
     |         |     closing parentheses


FILE: ...ules/contrib/cloudflare_stream_sync/src/Commands/SyncCommand.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 26 | ERROR | [x] There must be no blank lines after the function
    |       |     comment

Proposed resolution

Fix CS

CommentFileSizeAuthor
#2 3240836-fix_cs-2.patch6.91 KBtim-diels

Comments

tim-diels created an issue. See original summary.

tim-diels’s picture

Assigned: tim-diels » Unassigned
Status: Active » Needs review
StatusFileSize
new6.91 KB

Patch with changes provided.

tim-diels’s picture

Status: Needs review » Closed (outdated)