Problem/Motivation

The variable $instance declared in the foreach statement overrides the function argument $instance.

Proposed resolution

Modify the code so that it is not overwritten.

Issue fork cloud-3240733

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Ryo Yamashita created an issue. See original summary.

ryo yamashita’s picture

ryo yamashita commented
Issue summary: View changes

Ryo Yamashita opened merge request !441

ryo yamashita’s picture

ryo yamashita commented
Status: Needs work » Needs review

@yas

I have created a patch. Could you please check it?

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@ryo-yamashita

Thank you for the fix. It looks good to me. I'll merge the patch to 4.x and close this issue as Fixed.

  • yas committed e0381b1 on 4.x authored by Ryo Yamashita 
    Issue #3240733 by Ryo Yamashita, yas: Fix overridden local variable $...

yas closed merge request !441

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.