Problem/Motivation

Refresh related entities in worker site after running operations from master(k8s)

CommentFileSizeAuthor
#15 3240218_15_hotfix.patch523 bytesxiaohua guan

Issue fork cloud-3240218

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Xiaohua Guan created an issue. See original summary.

Xiaohua Guan opened merge request !426

xiaohua guan’s picture

xiaohua guan commented
Status: Active » Needs review

@yas

Please review the commit code. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@xiaohua-guan

Thank you for the patch. I posted my comments above. Could you please check them? Thanks!

xiaohua guan’s picture

xiaohua guan commented
Status: Needs work » Needs review

@yas

Thanks for your comments. I've fixed them. Please review it. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@xiaohua-guan

Thank you for the update. I posted my comment. Basically we should avoid placing the string itself due to the human typing mistake. Thanks

xiaohua guan’s picture

xiaohua guan commented
Status: Needs work » Needs review

@yas

Thanks for the comment. I've fixed it. Please check it. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

@xiaohua-guan

Thank you for the update. It is getting close to be perfect. I posted my comment; so could you please check the ones? Thanks!

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work
xiaohua guan’s picture

xiaohua guan commented
Status: Needs work » Needs review

@yas

Sorry for the mistake. I've fixed it. Please check it again. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Title: Refresh related entities in worker site after running operations from master(k8s) » Refresh K8s entities on worker site after running operations from master
Status: Needs review » Reviewed & tested by the community

@xiaohua-guan

Thank you for the update. Now the patch looks even more clearer. I'll merge the patch to 4.x and close this issue as Fixed.

  • yas committed ab8694f on 4.x authored by Xiaohua Guan 
    Issue #3240218 by Xiaohua Guan, yas: Refresh K8s entities on worker site...

yas closed merge request !426

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed
xiaohua guan’s picture

xiaohua guan commented
Status: Fixed » Needs review
StatusFileSize
new 3240218_15_hotfix.patch523 bytes

@yas

Sorry for the mistake. Please check the hot fix. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@xiaohua-guan

Thank you for the fix. I'll merge the patch to 4.x and close this issue as Fixed.

  • yas committed 3f8cd2f on 4.x authored by Xiaohua Guan 
    Issue #3240218 by Xiaohua Guan, yas: Hotfix - Refresh K8s entities on...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.