Problem/Motivation

\Drupal\comment\Entity\Comment::getThread can cause deprecations on PHP 8.1 because it can return a NULL.

Steps to reproduce

Run core/modules/comment/tests/src/Kernel/CommentFieldAccessTest.php on PHP 8.1

Proposed resolution

Fix \Drupal\comment\Entity\Comment::getThread to not return NULL or comment up with something better.

Remaining tasks

review/commit

User interface changes

no

API changes

no

Data model changes

no

Release notes snippet

no

CommentFileSizeAuthor
#10 interdiff.txt457 bytesandypost
#9 3240172-9.patch1.58 KBandypost
#6 3240172-6.patch1.37 KBandypost
#6 3240172-6-fail.patch869 bytesandypost
#5 3240172-5.patch533 bytesandypost
#2 3240172-2.patch490 bytesalexpott

Comments

alexpott created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Active » Needs review
Issue tags: +PHP 8.1
Parent issue: » #3220021: [meta] Ensure compatibility of Drupal 9 with PHP 8.1 (as it evolves)
StatusFileSize
new 3240172-2.patch490 bytes

Status: Needs review » Needs work

The last submitted patch, 2: 3240172-2.patch, failed testing. View results

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Needs work » Needs review

Random JS test fail.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Issue summary: View changes
StatusFileSize
new 3240172-5.patch533 bytes

I think it's better to remove useless call to "empty()" and just process result

it may need a test to fix current expectations from the method

andypost’s picture

andypost
he/him
Primary language Russian
commented
StatusFileSize
new 3240172-6-fail.patch869 bytes
new 3240172-6.patch1.37 KB

Here's a test

The last submitted patch, 6: 3240172-6-fail.patch, failed testing. View results

Status: Needs review » Needs work

The last submitted patch, 6: 3240172-6.patch, failed testing. View results

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs work » Needs review
StatusFileSize
new 3240172-9.patch1.58 KB

Included changes from #3240171: \Drupal\comment\Entity\Comment::getSubject() can cause deprecations on PHP 8.1

andypost’s picture

andypost
he/him
Primary language Russian
commented
StatusFileSize
new interdiff.txt457 bytes

interdiff from #6

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Needs review » Closed (duplicate)

@andypost rather than combining issues we should work out why the NULL return matters, document that and consider the best fix. That said I'm going to merge the thread part of this one with #3240167: \Drupal\comment\CommentStorage::getMaxThread() and \Drupal\comment\Entity\Comment::getThread() cause deprecations on PHP 8.1 because that's all about threads.