Fixing the tests in the branch and remove deprecated code from the tests
Run tests
Functional Tests:
Unit Tests:
\Drupal::$container is not initialized yet. \Drupal::setContainer() must be called with a real container.Fix Functional Tests
Fix Unit Tests
Test it
Commit
| Comment | File | Size | Author |
|---|---|---|---|
| #11 | 3239671-11-fix-coding-standards.patch | 61.94 KB | daften |
| #10 | interdiff_5_7.patch | 9.34 KB | beatrizrodrigues |
| #10 | 3239671-7-fix-tests.patch | 63.92 KB | beatrizrodrigues |
| #7 | 3239671-6-fix-tests.patch | 60.62 KB | beatrizrodrigues |
| #5 | 3239671-5-fix-tests.patch | 0 bytes | daften |
Comments
Comment #2
hmendes commentedAdding a patch to fix the Functional tests.
The Unit tests still needs to be fixed, so changing this to needs work
Comment #3
daften commentedI've fixed the unit tests, took a bit of time to fix all deprecations in phpunit, ... and then fix the tests. Let's see :)
Comment #4
daften commentedSomething went wrong with the previous patch it seems
Comment #5
daften commentedFixed coding standards in the patch file.
@hmendes feel free to give feedback. If it's okay or no feedback by this weekend, I'll probably merge this patch.
Comment #6
beatrizrodriguesComment #7
beatrizrodriguesSo, I tested and all the tests are passing, with no deprecation messages. I run phpcs command to find some code sniffs and I actually fixed some. (The patch before was empty :/ so that's why I worked on fix code standard again). Sending the patch here.
I will also open a issue to update the README file, 'cause the maintainers list there is very outdated.
Comment #9
beatrizrodriguesThe tests are failing, i'll check why.
Comment #10
beatrizrodriguesI fixed the mistakes I did at the previous patch and I'm also sending a interdiff file :)
Comment #11
daften commentedHi Beatriz. I still had my original file here and I'll use that one. There are some mistakes in your patch file it seems, I mainly don't understand why you've removed all the translation functions. If you feel that's needed, feel free to open a new issue with a separate patch file. I'll credit you for the work you've put in though, I appreciate the contribution a lot!
In attachment the patch file that will be used
Comment #13
daften commentedComment #14
beatrizrodriguesOh, thank you @daften! I will check what I did wrong so I can do different in the future. About the translations functions, I talked with a colleague that is a drupal contributor here too, and we came to a conclusion that the functions were not necessary as it is a test, phpcs keeps throwing this warning about it, so I took it off. But if it is a good practice to let it, that's ok. Thank you again.