Problem/Motivation

Part of #3220021: [meta] Ensure compatibility of Drupal 9 with PHP 8.1 (as it evolves)

Steps to reproduce

Docs said it returns bool https://www.php.net/manual/en/filteriterator.accept.php

Proposed resolution

fix

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#2 3239556-2.patch501 bytesandypost

Comments

andypost created an issue. See original summary.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Assigned: Unassigned » alexpott
Status: Active » Needs review
StatusFileSize
new 3239556-2.patch501 bytes

Patch parent META

andypost’s picture

andypost
he/him
Primary language Russian
commented
Component: views.module » migration system

Status: Needs review » Needs work

The last submitted patch, 2: 3239556-2.patch, failed testing. View results

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs work » Needs review

looks unrelated failure, re-queued

daffie’s picture

daffie commented

The class Drupal\Component\FileSystem\RegexDirectoryIterator also extends FilterIterator shall we do the class too. THerte are no overrides in contrib for this class. See: http://grep.xnddx.ru/search?text=RegexDirectoryIterator&filename=

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Needs review » Reviewed & tested by the community

@daffie that already has a #[\ReturnTypeWillChange] annotation. Let's leave that alone here. We can fix this one test instance (because it is test code) and then decide how to fix return types more generally later.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Assigned: alexpott » Unassigned
catch’s picture

catch
he/him
Primary language English
commented

Committed 3745a46 and pushed to 9.3.x. Thanks!

  • catch committed 3745a46 on 9.3.x 
    Issue #3239556 by andypost: Fix return type of \Drupal\Tests\migrate\...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.