Problem/Motivation
In #3236497: Allow other modules to opt out or use verbose security release message from update_page_top we are going remove the hard-coded list of routes that update security messages should NOT be displayed on and replace it with a route option.
for modules the update module does not provide it will be set the option in UpdateRouteSubscriber
Right now the update module only excludes 2 paths besides its own system.theme_install, system.status.
It should also exclude system.batch_page.html as the messages are never displayed on the batch pages but if the hook is still called on this rout. This means that pages after batch may have the message even if they are excluded in update_page_top() because the message service will display the message from the previous request.
I can't think of a reason why the we need to set the message during batch.
We have to exclude it here #3236405: After update old message about security update is still displayed in the Automatic Updates module but it should be the Update module's responsibility to exclude this path.
Proposed resolution
Exclude system.batch_page.html in update_page_top() or after #3236497: Allow other modules to opt out or use verbose security release message from update_page_top exclude it in UpdateRouteSubscriber
Remaining tasks
Issue fork drupal-3238311
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
tedbowLooks good!
Comment #3
tedbowwhoops wrong tab
Comment #4
phenaproximaComment #6
dwwLooks like this needs review, updating status. No time right now to closely review it, doing some informal update.module issue queue triage...
Thanks,
-Derek
Comment #7
dwwp.s. I'm tempted to call this a bug. We almost certainly shouldn't be setting this message while processing batches. I think that was 100% an oversight in the original implementation.
Comment #9
joachim commentedLGTM.
Comment #10
alexpottI agree with @dww - this is a bug.
Committed and pushed f37eaca35b8 to 10.0.x and 75edbaebbff to 9.4.x and 61a12bcdb52 to 9.3.x. Thanks!