Problem/Motivation

There is some duplicated code in Drupal\system\Form\ModulesListForm and Drupal\system\Form\ModulesListConfirmForm. It will be easier to maintain if we consolidate some of that code.

Proposed resolution

In #3216341: Provide a module-specific permissions form, we added Drupal\system\Form\ModulesEnabledTrait in order to avoid adding more duplicated code. Let's move some of the existing code to the new trait.

Remaining tasks

User interface changes

None

API changes

None

Data model changes

None

Release notes snippet

None

Issue fork drupal-3236446

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

benjifisher created an issue. See original summary.

benjifisher’s picture

benjifisher
he/him or they/them
Primary language English
Location Boston area
commented
Related issues: +#3216341: Provide a module-specific permissions form

paulocs made their first commit to this issue’s fork.

paulocs opened merge request !1240

paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
commented
Status: Active » Needs review
gabriel.abdalla’s picture

gabriel.abdalla commented
Status: Needs review » Reviewed & tested by the community

Hi, I reviewed the code and changes look fine to me.

  • catch committed 324ddcd on 9.3.x 
    Issue #3236446 by paulocs, benjifisher: Avoid duplicated code for the...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed 324ddcd and pushed to 9.3.x. Thanks!

benjifisher’s picture

benjifisher
he/him or they/them
Primary language English
Location Boston area
commented

When I created the issue, I thought there would be more duplicated code, but I think the MR catches it all.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.