Problem/Motivation

Some functionality is hidden due to issue with filters, please see css.png
I found out that the following patch should resolve the issue: https://www.drupal.org/project/drupal/issues/2998908

Steps to reproduce

  1. go to layout builder
  2. pick image block
  3. click on add image
  4. an additional popup will be displayed
  5. check source, filters are hidden through css

Proposed resolution

Remove css, add patch to composer file

CommentFileSizeAuthor
#3 show_filter_section.patch1.64 KBalorenc
css.png57.08 KBalorenc

Issue fork rocketship_core-3230002

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

alorenc created an issue. See original summary.

alorenc opened merge request !11

alorenc’s picture

alorenc
Location Wolsztyn, 🇵🇱
commented
StatusFileSize
new show_filter_section.patch1.64 KB
alorenc’s picture

alorenc
Location Wolsztyn, 🇵🇱
commented
Assigned: alorenc » Unassigned
Status: Active » Needs review
rembrandx’s picture

rembrandx commented

Hi Alorenc, the reason the filters are being hidden at the moment, is because they are not fully functional in Rocketship. There's some bugs for example, breaking sorting when looking at media to add to the Image block. I think that's what you are trying to patch here.
Until we have fixes for this, we've decided to hide the filters.

EDIT: we'll test the patch and see if it fixes all the sorting issues.

rembrandx’s picture

rembrandx commented
Status: Needs review » Needs work
rembrandx’s picture

rembrandx commented
Status: Needs work » Needs review
Related issues: +#3216875: Filters and sorting doesn't work in Media Library modal window
rembrandx’s picture

rembrandx commented

I marked the related issue so we can close both of these when we've tested the provided + the linked patches.
Thanks for the help!

rembrandx’s picture

rembrandx commented
Related issues: +#1551534: Submit buttons themed as <button> element fail to trigger ajax in Views exposed forms

Digging in deeper, the deeper issue is this one: https://www.drupal.org/project/drupal/issues/1671190

For now, I'm adding the patch from this issue which is more complete than the suggested one: https://www.drupal.org/project/drupal/issues/1551534
Which we will have to remove in D9.3

  • rembrandx committed f3560e7 on 6.x 
    [#3230002] - patch ajax filters in Views so we can reenable sorting in...
rembrandx’s picture

rembrandx commented
Version: 6.0.0-alpha11 » 6.0.0-alpha15
Status: Needs review » Fixed

rembrandx closed merge request !11

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.