Problem/Motivation

Fatal error: Declaration of Drupal\lupus_ce_renderer\Cache\CustomElementsJsonResponse::isRedirect($location = NULL) must be compatible with Symfony\Component\HttpFoundation\Response::isRedirect(?string $location = NULL): bool in /app/web/modules/contrib/lupus_ce_renderer/src/Cache/CustomElementsJsonResponse.php on line 47

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#3 lupus_ce_renderer_fatal_is_redirect.patch537 bytesfago

Comments

fago created an issue. See original summary.

fago’s picture

fago
Primary language German
Location Vienna
commented

the symfony repsonse object changed!

public function isRedirect(string $location = null): bool

Not sure it's possible to properly support 9.* and 8.9 here.

fago’s picture

fago
Primary language German
Location Vienna
commented
StatusFileSize
new lupus_ce_renderer_fatal_is_redirect.patch537 bytes

Anyway, this is for d9 compatibility.

fago’s picture

fago
Primary language German
Location Vienna
commented
Assigned: Unassigned » mostepaniukvm
Status: Active » Needs review

  • mostepaniukvm committed 536ea1d on 2.x authored by fago 
    Issue #3229623 by fago: Fatal CustomElementsJsonResponseFatal error:...
mostepaniukvm’s picture

mostepaniukvm
he/him
commented
Version: 8.x-1.x-dev » 2.x-dev
Assigned: mostepaniukvm » Unassigned
Status: Needs review » Fixed

created d9 only branch 2.x and merged

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.