Rename "Account cancellation" to "Account closure" in UI

There likely is some usage of "cancel" in user email templates and associated tokens, so noting those in the summary.

Hi Anul

First part for UI terms changes and Second part for backend functions, variables, callbacks, routings, etc name changes, as all of them will require good amount of unit testing.

Yes I think that's a sensible idea, I was also thinking that might be a good option, as it better addresses backwords compatibility. We don't necessarily need a backwards compatibility layer for the user interface and text changes, so these could be done for 9.3; The more technical changes would then require a BC-layer, or would need to be done in 10.0.x.

I'll ask for some more input from people in Slack.

Thanks,
-Aaron

Didn't receive any feedback in the contrib Slack channel, but this seems like a sensible way to do so let's just go with it.

Very thorough patch, good to see it also includes code comment updates, thanks!

1. Regarding comment #12, that'll be because the actions live in configuration system.action.user_cancel_user_action.yml
   

   -label: 'Cancel the selected user account(s)'
   +label: 'Close the selected user account(s)'
   

   To update the actions label for existing sites, we're going to need an update hook.

2. -    $this->selectCancel = $user->hasPermission('administer users') || $user->hasPermission('select account cancellation method');
   +    $this->selectCancel = $user->hasPermission('administer users') || $user->hasPermission('select account closure method');
   ...
   -    $selectCancel = $user->hasPermission('administer users') || $user->hasPermission('select account cancellation method');
   +    $selectCancel = $user->hasPermission('administer users') || $user->hasPermission('select account closure method');
   ...
   -    // Repeat with permission to select account cancellation method.
   -    $user->addRole($this->drupalCreateRole(['select account cancellation method']));
   +    // Repeat with permission to select account closure method.
   +    $user->addRole($this->drupalCreateRole(['select account closure method']));
   ...
   -    'access' => $account->hasPermission('access zero-out account cancellation method'),
   +    'access' => $account->hasPermission('access zero-out account closure method'),
   ...
   -select account cancellation method:
   -  title: 'Select method for cancelling account'
   +select account closure method:
   +  title: 'Select method for closing account'
   

   The permission ID can't be changed in this issue as that would be a BC-break, which we're leaving for the follow-up issue, so this needs to stay select account cancellation method etc. It is however fine to change the title of the permission to Select method for closing account etc.

   -  $form['access']['#value'] = \Drupal::currentUser()->hasPermission('cancel other accounts');
   +  $form['access']['#value'] = \Drupal::currentUser()->hasPermission('close other accounts');
   ...
   -cancel other accounts:
   -  title: 'Cancel other user accounts'
   +close other accounts:
   +  title: 'Close other user accounts'
   ...
   -    $admin_user = $this->drupalCreateUser(['cancel other accounts']);
   +    $admin_user = $this->drupalCreateUser(['close other accounts']);
   

   Same as above. Permission title is fine to change, but not the permission ID.

Setting to needs work for both of those.

Thanks,
-Aaron

#3199972: Improve user interface text on the account cancellation screen was just committed, making it easier to get this done now.

We'll be looking at this issue at #3244123: Drupal Usability Meeting 2021-10-22, at this stage it doesn't need an actual review since this issue came directly out of a previous UX meeting.