Problem/Motivation

There is an outdated @todo in HtmlResponseAttachmentsProcessor::processAttachments(); the referenced issue was resolved about a month after the subject code was committed.

Issue fork drupal-3228656

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

bradjones1 created an issue. See original summary.

bradjones1 opened merge request !1078

bradjones1’s picture

bradjones1
Primary language English
commented
Status: Active » Needs review
Parent issue: » #2408013: Adding Assertions to Drupal - Test Tools.
spokje’s picture

spokje
Primary language Dutch
commented
Status: Needs review » Reviewed & tested by the community

- Referenced issue in @todo was indeed marked as closed.
- The mentioned action (replace with assertion) in the @todo is indeed done in the MR.
- TestBot is green (and we all know it's not easy being green...)

RTBC for me.

  • catch committed fdfc5c6 on 9.3.x 
    Issue #3228656 by bradjones1, Spokje: Remove outdated @todo in...

  • catch committed 4d0a7ba on 9.2.x 
    Issue #3228656 by bradjones1, Spokje: Remove outdated @todo in...
catch’s picture

catch
he/him
Primary language English
commented
Version: 9.3.x-dev » 9.2.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 9.3.x and cherry-picked to 9.2.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.