Problem/Motivation

If data is missing in paragraphs_bundle table, migration will fail with error Undefined array key "paragraph_bundle_name"

Steps to reproduce

Remove some entries from paragraphs_bundle table and then do migration

Proposed resolution

Modify Paragraphs Type source plugin to handle missing Pargraphs bundle

Remaining tasks

None

User interface changes

None

API changes

None

Data model changes

None

CommentFileSizeAuthor
#13 interdiff-3228554-7-13.txt5.89 KBhuzooka
#13 missing_paragraph_bundle-3228554-13.patch7.44 KBhuzooka
#12 interdiff-3228554-7-12.txt5.27 KBhuzooka
#12 missing_paragraph_bundle-3228554-12.patch7.43 KBhuzooka
#11 interdiff-3228554-7-11.txt5.77 KBhuzooka
#11 missing_paragraph_bundle-3228554-11.patch7.93 KBhuzooka
#10 interdiff-3228554-7-10.txt5.29 KBhuzooka
#10 missing_paragraph_bundle-3228554-10.patch7.42 KBhuzooka
#9 missing_paragraph_bundle-3228554-9--on-top-of-3226658-8--3145755-43.patch3.16 KBnarendrar
#8 missing_paragraph_bundle-3228554-8--on-top-of-3226658-8--3145755-43.patch565.53 KBnarendrar
#7 missing_paragraph_bundle-3228554-7.patch3.18 KBnarendrar
#5 missing_paragraph_bundle-3228554-5.patch2.26 KBnarendrar
#4 missing_paragraph_bundle-3228554-4.patch2.25 KBnarendrar
#2 missing_paragraph_bundle-3228554-2.patch2.26 KBnarendrar

Comments

narendraR created an issue. See original summary.

narendrar’s picture

narendrar
He/Him
Primary language English
Location Jaipur, India
commented
Status: Active » Needs review
StatusFileSize
new missing_paragraph_bundle-3228554-2.patch2.26 KB

Initial patch

Status: Needs review » Needs work

The last submitted patch, 2: missing_paragraph_bundle-3228554-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

narendrar’s picture

narendrar
He/Him
Primary language English
Location Jaipur, India
commented
StatusFileSize
new missing_paragraph_bundle-3228554-4.patch2.25 KB

Updated patch

narendrar’s picture

narendrar
He/Him
Primary language English
Location Jaipur, India
commented
Status: Needs work » Needs review
StatusFileSize
new missing_paragraph_bundle-3228554-5.patch2.26 KB

Updated patch

Status: Needs review » Needs work

The last submitted patch, 5: missing_paragraph_bundle-3228554-5.patch, failed testing. View results

narendrar’s picture

narendrar
He/Him
Primary language English
Location Jaipur, India
commented
Status: Needs work » Needs review
StatusFileSize
new missing_paragraph_bundle-3228554-7.patch3.18 KB

Another one :)

narendrar’s picture

narendrar
He/Him
Primary language English
Location Jaipur, India
commented
StatusFileSize
new missing_paragraph_bundle-3228554-8--on-top-of-3226658-8--3145755-43.patch565.53 KB

Patch on top of
https://www.drupal.org/project/paragraphs/issues/3226658#comment-14182708 and https://www.drupal.org/project/paragraphs/issues/3145755#comment-14185403

narendrar’s picture

narendrar
He/Him
Primary language English
Location Jaipur, India
commented
StatusFileSize
new missing_paragraph_bundle-3228554-9--on-top-of-3226658-8--3145755-43.patch3.16 KB

Working Patch on top of
https://www.drupal.org/project/paragraphs/issues/3226658#comment-14182708 and https://www.drupal.org/project/paragraphs/issues/3145755#comment-14185403

huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
commented
StatusFileSize
new missing_paragraph_bundle-3228554-10.patch7.42 KB
new interdiff-3228554-7-10.txt5.29 KB

#7 does not migrate those paragraph types which don't have any paragraph entity instances.

This patch solves this issue by using a union. I also attach a migrate source plugin test for ParagraphsType.

huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
commented
StatusFileSize
new missing_paragraph_bundle-3228554-11.patch7.93 KB
new interdiff-3228554-7-11.txt5.77 KB

Please ignore #10.

huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
commented
StatusFileSize
new missing_paragraph_bundle-3228554-12.patch7.43 KB
new interdiff-3228554-7-12.txt5.27 KB

..and ignore #11.

huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
commented
StatusFileSize
new missing_paragraph_bundle-3228554-13.patch7.44 KB
new interdiff-3228554-7-13.txt5.89 KB

Fixing CS + update test added in #7 (compatibility with current HEAD).