Problem/Motivation

From Commerce 2.25, instantiating payment gateway plugins requires passing the minor units converter (See #3150917: Create a MinorUnitsConverter service).

CommentFileSizeAuthor
#2 3228538-2.patch16.93 KBjsacksick

Comments

jsacksick created an issue. See original summary.

jsacksick’s picture

jsacksick commented
Status: Active » Needs review
StatusFileSize
new 3228538-2.patch16.93 KB

Status: Needs review » Needs work

The last submitted patch, 2: 3228538-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

jsacksick’s picture

jsacksick commented
Title: Pass the minor units converter » Stop overridding the constructors in our gateway plugins to ensure new dependencies are automatically inherited.
Status: Needs work » Fixed

The test failure is unrelated, committed!

  • jsacksick committed 4c97b79 on 8.x-1.x 
    Issue #3228538 by jsacksick: Stop overridding the constructors in our...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.