Problem/Motivation

Bad things happen if both quick_edit and manage_display_fix_title modules are enabled at the time since both declare the a function with the same name: quickedit_preprocess_entity_page_title. manage_display_fix_title should declare its own version of quickedit_preprocess_entity_page_title in its own namespace.

Even if both modules were programmatically prevented from being installed at the same time, it will still cause static analysis tooling like PHPStan to blow up, unless exceptions are added, which is undesirable.

Steps to reproduce

Enable both quick_edit and manage_display_fix_title modules.

Proposed resolution

Rename the function declared in manage_display_fix_title.module.

Issue fork manage_display-3228275

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

dpi created an issue. See original summary.

dpi opened merge request !3

AdamPS made their first commit to this issue’s fork.

  • AdamPS committed 79b50c3 on 8.x-1.x authored by dpi 
    Issue #3228275 by dpi: Enabling fix_title submodule and quickedit at the...
adamps’s picture

adamps commented
Status: Active » Fixed

Thanks

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.