Same as issue 2054059, but for 8.x-1.1.

Now that configuration is in config/install/readonlymode.settings.yml, it seems it's necessary to add views_exposed_form to the array forms.default.edit.

CommentFileSizeAuthor
#3 rom_views_exposed_form.patch434 bytesrichard.walker.ardc

Issue fork readonlymode-3228261

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

richard.walker.ardc created an issue. See original summary.

richard.walker.ardc’s picture

richard.walker.ardc commented
Title: Read Only does not work for views with exposed filters (8.x » Read Only does not work for views with exposed filters (8.x)
richard.walker.ardc’s picture

richard.walker.ardc commented
StatusFileSize
new rom_views_exposed_form.patch434 bytes

Patch attached.

richard.walker.ardc’s picture

richard.walker.ardc commented
Status: Active » Needs review
matoeil’s picture

matoeil commented
Status: Needs review » Needs work

i have :
- added the line of code from the patch
- uninstall the module and reinstall,
- activate the read-only mode

A view with an exposed filter is still not visible

richard.walker.ardc’s picture

richard.walker.ardc commented

Please confirm what you mean by "uninstall".

If you only used the admin interface Administration -> Extend -> Uninstall, or if you used drush pmu, this didn't remove the module and the patch from your file system. So if you then re-installed, you were re-installing with the patch.

matoeil’s picture

matoeil commented

using the admin interface

richard.walker.ardc’s picture

richard.walker.ardc commented

Ah ... yes. I've been able to reproduce this. :-(

Thank you for reporting. I guess I'll try to see what is going on.

richard.walker.ardc’s picture

richard.walker.ardc commented

Note to self: after uninstall/reinstall, if I view the config (admin/config/development/configuration/single/export, Simple configuration/readonlymode.settings), the value views_exposed_form is gone from forms.default.edit. So the patch "got lost" somehow.

Update: Oh, this is because I didn't even install my own patch, but I'd modified the configuration manually after the original install, so it's no wonder it wasn't there after uninstall/reinstall.

More to come, once I've had a chance to re-test after actually applying the patch ....

solideogloria’s picture

solideogloria commented
Version: 8.x-1.1 » 8.x-1.x-dev
solideogloria’s picture

solideogloria commented
Title: Read Only does not work for views with exposed filters (8.x) » Read Only does not work for views with exposed filters

astonvictor made their first commit to this issue’s fork.

astonvictor opened merge request !13

astonvictor’s picture

astonvictor commented
Status: Needs work » Needs review

Works for me with Drupal 10.3

not sure but I guess an old version of the Drupal has different statuses for the module: disabled and uninstalled.
Currently, after uninstalling the module, I don't have a config on the /admin/config/development/configuration/single/export page and after installing again I can see a new line.

It's also possible to create a new update function to update the config for existing projects.

astonvictor’s picture

astonvictor commented
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.