When using the "Convert the existing terms in this vocabulary immediately" feature, the termcase_update_term() function does not properly save updated terms. It should be using the Drupal entity API, instead if does a direct database UPDATE statement which doesn't update the revision table.
Use the "Convert the existing terms in this vocabulary immediately" feature and notes that the revision table doesn't get updated, so term names don't actually get updated properly.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | does_not_properly_save_terms-3228215-3.patch | 1.55 KB | ultimike |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
ultimikePatch attached.
-mike
Comment #3
ultimikeWhoops! Forgot the "use" statement in the previous patch. New patch attached.
-mike
Comment #4
dabley commentedIs more work needed here, or should the status be "Needs Review"?
Comment #5
ultimikeYep, "needs review" - I forgot to change the status!
thanks,
-mike
Comment #6
dabley commentedPatch #3 works ok for me (with D9.3.2). Without the patch, values in table taxonomy_term_field_data get updated, but not values in table taxonomy_term_field_revision. In the admin interface, it looks as though the terms have not been updated at all (even after doing a cache rebuild). After applying the patch, terms are updated in both tables, and the admin interface shows the revised term names (without even needing a cache rebuild).
Comment #10
astonvictor commentedCreated and merged a new MR.
Fixed the batch.