Closed (fixed)
Project:
Paragraphs Report
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
10 Aug 2021 at 18:20 UTC
Updated:
24 May 2024 at 14:00 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
redsky commentedComment #3
anacolautti commentedI tested out the suggestion from @redsky on drupal 9.2 and It worked for me. Please someone else review it as well.
Comment #4
anacolautti commentedmy bad, I generated last patch wrong.
Comment #5
huijse commentedWorks
Comment #6
huijse commentedComment #7
eric_a commentedThe path_alias.manager service exists since 8.8.0 *but* the providing core module is no longer a required one. So:
Change records:
Comment #8
eric_a commentedHere's an updated patch that addresses #7.
It applies to both the HEAD of 8.x-1.x-dev and to the 8.x-1.0 release build artefact. To make it apply to both I deliberately ordered the new dependency wrongly in the info.yml file. If this gets committed it would be best to fix the order before commit.
@huijse, does this still work for you?
Comment #9
eric_a commentedComment #10
eric_a commentedOops, there are still references to \Drupal\Core\Path\AliasManager.
Will fix and I'll also provide an interdiff between #4 and the next patch.
Comment #11
eric_a commentedLike in #8, this applies to both the HEAD of 8.x-1.x-dev and to the 8.x-1.0 release build artefact. To make it apply to both I deliberately ordered the new dependency wrongly in the info.yml file. If this gets committed it would be best to fix the order before commit.
Comment #12
eric_a commentedComment #13
eric_a commentedMaintainers, please credit @web-beest for pinging me about the references to deprecated \Drupal\Core\Path\AliasManager.
Comment #14
xaa commentedhi, I confirm patch #11 is working. thank you
Comment #15
robert ngoThe patch from #11 is working correctly.
Thank you
Comment #16
aisforaaron commentedMerged in, thanks!
Comment #17
eric_a commented@aisforaaron, thanks for committing this and thanks for releasing 1.1!
I'm reviewing all changes since f156ac5 and noticed that your commit associated with the service fix has also reverted an earlier bug fix commit. Which worries me a little.
Commit 23434b1 has reverted the checks and error message in
batchSetup()from commit f156ac5.Was this done deliberately or an accident?
Comment #18
eric_a commentedThe reverted code had no issue number in the commit message, but I think the commit belonged to #3053444: Type error. I'll comment there.
Comment #19
nicholassI too am now having issues after updating, I think there was a bug introduced with the latest version I am getting notices now after updating content
Notice: Undefined index pg_card ..... /modules/contrib/paragraphs_report/src/ParagraphsReport.php on line 670Comment #22
generalredneckcredit
Comment #23
xaa commented