Hreflang on non-canonical content pages

It seems like a better way to fix this would be for Content Translation module to add whatever query string is present to each hreflang URL.

Analogously, Language module adds $request->query->all() to each URL in the getLanguageSwitchLinks() method: https://git.drupalcode.org/project/drupal/-/blob/9.4.x/core/modules/lang... and I'd say Content Translation module should have similar code.

Moving to current branch and adding "Needs tests" tag

Ok, I noticed a couple problems with this MR, so setting to needs work.

1. The logic is wrong, such that hreflang tags for translations aren't added - this is reflected in the test failures.
2. The hreflang tags are cached, without query string as a cache context. As a result, cached hreflang tags will end up being present even if the logic here says they should not be added.

Note: Caching would also be at issue with regards to my alternate approach suggested in #9: We'd have to vary the cached hreflang tags per query string.

Here's a take on #9 - adding query string to the hreflang tags.

Changing some more test expectations for the new cache context

The one unfortunate side effect of adding the url.query_args cache context is extra caches being generated and stored for each set of query arguments used with entity pages. I suppose this could be worked around through the use of lazy builder placeholders for the link tag href attributes?

Not sure how often accessibility meets.

But there are two proposed solutions can it be highlighted which was chosen please.

One potential challenge with this would be when not all content is translated across all languages. For example, if on a US site you had 17 pages of articles but on the CA site there were only 5, what would the appropriate hreflang tags be on ?page=17 of the US site?

@mytungsten That is also a challenge outside of this issue, as if a site uses the built-in language switcher block, then they will get switch links that include such query arguments.

@smustgrave As far as which proposed solution was chosen, option B seemed like a good idea to me for cache efficiency reasons, but there is no patch for option B as of yet. So I'd say this issue probably needs both review to determine a solution, and a new patch/MR to be developed.

Reading the 2 options like the idea of using lazy builder too. Moving to NW for that patch.

Hi everyone, I have update to the last version of core (10.2.3) and it seems that the patch does'nt apply anymore. Any idea?

Re-rolled patch #14 against Drupal 10.2.3

#27 seems working for 10.2.10 . Need to check if it pass test cases.

Created a MR(10476) with the changes for 11.x. Please check

Hmm, the MR seems to include numerous unrelated changes/fixes? If we decide to go with "Option A" then we would need a cleaner MR (basically just the patch). But in #25 we discussed that we could potentially instead go with "Option B": re-architect hreflang tags to use a lazy builder to add query string to the hreflang links. We don't have a merge request for "Option B" yet.

I cannot apply the MR for d11.