Problem/Motivation

  • Update AWS resource status with REST API

Proposed resolution

  • Add a REST API to the cloud module to update AWS entity
CommentFileSizeAuthor
#8 スクリーンショット 2021-08-06 10.53.29.png38.22 KBRyo Yamashita

Issue fork cloud-3226828

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Ryo Yamashita created an issue. See original summary.

Ryo Yamashita opened merge request !333

Ryo Yamashita’s picture

Ryo Yamashita commented
Status: Needs work » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Title: Add a REST API to update AWS entity » Add a REST API to update AWS Cloud entity
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work
Ryo Yamashita’s picture

Ryo Yamashita commented
Status: Needs work » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@ryo-yamashita

Thank you for the update. I tried to apply the patch and received the following error. Could you please rebase the patch? Thanks!

error: patch failed: modules/cloud_service_providers/aws_cloud/aws_cloud.routing.yml:798
error: modules/cloud_service_providers/aws_cloud/aws_cloud.routing.yml: patch does not apply
error: patch failed: modules/cloud_service_providers/aws_cloud/src/Controller/Ec2/ApiController.php:622
error: modules/cloud_service_providers/aws_cloud/src/Controller/Ec2/ApiController.php: patch does not apply
error: patch failed: modules/cloud_service_providers/aws_cloud/src/Controller/Ec2/ApiControllerInterface.php:132
error: modules/cloud_service_providers/aws_cloud/src/Controller/Ec2/ApiControllerInterface.php: patch does not apply
error: patch failed: modules/cloud_service_providers/aws_cloud/src/Service/Ec2/Ec2Service.php:1279
error: modules/cloud_service_providers/aws_cloud/src/Service/Ec2/Ec2Service.php: patch does not apply
error: patch failed: modules/cloud_service_providers/aws_cloud/src/Service/Ec2/Ec2ServiceInterface.php:1853
error: modules/cloud_service_providers/aws_cloud/src/Service/Ec2/Ec2ServiceInterface.php: patch does not apply
Ryo Yamashita’s picture

Ryo Yamashita commented
StatusFileSize
new スクリーンショット 2021-08-06 10.53.29.png38.22 KB

@yas

Thank you for reporting this error message. In this screenshot, the following message is displayed, and rebase is not available by d.o.

Therefore, when I run the rebase command locally, I see that a conflict occurs.

Is it OK to commit after resolving the conflict and then push it?

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Issue summary: View changes

@ryo-yamasthia

Yes you need to rebase locally: "Fast-forward merge is not possible. To merge this request, first rebase locally." It is simply a git repository so we can use the common git commands.

Ryo Yamashita’s picture

Ryo Yamashita commented
Status: Needs work » Needs review

@yas

I rebased and pushed the fix commit. Please check this commit.

yas closed merge request !333

  • yas committed c42f96b on 4.x authored by Ryo Yamashita 
    Issue #3226828 by Ryo Yamashita, yas: Add a REST API to update AWS Cloud...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Fixed

@ryo-yamashita

Thank you for the update. I merged the patch to 4.x and closing this issue as Fixed.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Issue summary: View changes
Related issues: +#3226882: Add a REST API to count AWS Cloud entities, +#3227078: Add a REST API to stop AWS Cloud instance, +#3225597: Set custom permission for REST API to count K8s entities, +#3228270: Add a REST API to restart AWS Cloud instance, +#3228276: Add a REST API to delete AWS Cloud instance, +#3228432: Refactor REST APIs to handle AWS Cloud Instance entities

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.