Problem/Motivation

We are currently using cspell 4.2.8. cspell 5 was released last year and is currently at 5.6.6.

Recent releases are over twice as fast to regenerate the dictionary:

cspell 4.2.8:

CSpell: Files checked: 15688, Issues found: 34124 in 7861 files
Done in 463.34s.

cspell 5.6.6:

CSpell: Files checked: 15479, Issues found: 33264 in 7775 files
Done in 220.63s.

Steps to reproduce

Proposed resolution

Update to cspell@^5.0.0 and regenerate the dictionary.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

cspell has been updated from version 4 to 5, this results in some slight changes to the dictionary.

Issue fork drupal-3226052

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

longwave created an issue. See original summary.

longwave opened merge request !988

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented
Status: Active » Needs review

alexpott made their first commit to this issue’s fork.

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented
Status: Needs review » Reviewed & tested by the community

I scanned through the dictionary diff and spot checked a few removals that looked odd, but it turns out they were all false positives in one way or another, so the new version of cspell is more accurate than the old which is good.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Makes sense to get this in before the 9.3 alpha.

Committed 3eba4b3 and pushed to 9.3.x. Thanks!

  • catch committed 3eba4b3 on 9.3.x 
    Issue #3226052 by longwave, alexpott: Update to cspell 5
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Issue summary: View changes
Issue tags: +9.3.0 release notes

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.