Problem/Motivation

PHP 8.1 support will require some updates to our dependencies: #3220021: [meta] Ensure compatibility of Drupal 9 with PHP 8.1 (as it evolves)

Not all dependencies are fully updated yet, but at least Symfony, masterminds/html5 and mikey179/vfsstream have recent point releases that include PHP 8.1 compatibility fixes.

Steps to reproduce

Proposed resolution

$ composer update --with=phpunit/phpunit:^8

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

+--------------------------------------+-----------+-----------+
| Production Changes                   | From      | To        |
+--------------------------------------+-----------+-----------+
| laminas/laminas-escaper              | 2.7.0     | 2.8.0     |
| laminas/laminas-stdlib               | 3.3.1     | 3.4.0     |
| laminas/laminas-zendframework-bridge | 1.2.0     | 1.3.0     |
| masterminds/html5                    | 2.7.4     | 2.7.5     |
| symfony/console                      | v4.4.25   | v4.4.27   |
| symfony/debug                        | v4.4.25   | v4.4.27   |
| symfony/dependency-injection         | v4.4.25   | v4.4.27   |
| symfony/error-handler                | v4.4.25   | v4.4.27   |
| symfony/event-dispatcher             | v4.4.25   | v4.4.27   |
| symfony/http-foundation              | v4.4.25   | v4.4.27   |
| symfony/http-kernel                  | v4.4.25   | v4.4.28   |
| symfony/mime                         | v5.3.0    | v5.3.4    |
| symfony/process                      | v4.4.25   | v4.4.27   |
| symfony/routing                      | v4.4.25   | v4.4.27   |
| symfony/serializer                   | v4.4.25   | v4.4.27   |
| symfony/translation                  | v4.4.25   | v4.4.27   |
| symfony/validator                    | v4.4.25   | v4.4.27   |
| symfony/var-dumper                   | v5.3.0    | v5.3.4    |
| symfony/yaml                         | v4.4.25   | v4.4.27   |
+--------------------------------------+-----------+-----------+

+------------------------------------+---------+---------+
| Dev Changes                        | From    | To      |
+------------------------------------+---------+---------+
| composer/ca-bundle                 | 1.2.9   | 1.2.10  |
| composer/composer                  | 2.1.0   | 2.1.5   |
| instaclick/php-webdriver           | 1.4.7   | 1.4.9   |
| justinrainbow/json-schema          | 5.2.10  | 5.2.11  |
| mikey179/vfsstream                 | v1.6.8  | v1.6.9  |
| phar-io/manifest                   | 2.0.1   | 2.0.3   |
| phpunit/php-code-coverage          | 7.0.14  | 7.0.15  |
| phpunit/php-file-iterator          | 2.0.3   | 2.0.4   |
| phpunit/phpunit                    | 8.5.15  | 8.5.18  |
| sirbrillig/phpcs-variable-analysis | v2.11.0 | v2.11.2 |
| symfony/browser-kit                | v4.4.25 | v4.4.27 |
| symfony/css-selector               | v4.4.25 | v4.4.27 |
| symfony/dom-crawler                | v4.4.25 | v4.4.27 |
| symfony/filesystem                 | v4.4.25 | v4.4.27 |
| symfony/finder                     | v4.4.25 | v4.4.27 |
| symfony/lock                       | v4.4.25 | v4.4.27 |
| symfony/phpunit-bridge             | v5.3.0  | v5.3.4  |
+------------------------------------+---------+---------+
CommentFileSizeAuthor
#11 3224000-3-11.patch71.62 KBalexpott
#11 9-11-interdiff.txt2.37 KBalexpott
#9 3224000-2-9.patch71.62 KBalexpott
#9 6-9-interdiff.txt47.99 KBalexpott
#6 3224000-6.patch50.96 KBlongwave
#4 3224000-4.patch47.41 KBalexpott
#4 1-4-interdiff.txt5.63 KBalexpott
#2 3224000.patch43.63 KBlongwave

Comments

longwave created an issue. See original summary.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Active » Needs review
StatusFileSize
new 3224000.patch43.63 KB 
+--------------------------------------+---------+---------+
| Production Changes                   | From    | To      |
+--------------------------------------+---------+---------+
| laminas/laminas-escaper              | 2.7.0   | 2.8.0   |
| laminas/laminas-stdlib               | 3.3.1   | 3.4.0   |
| laminas/laminas-zendframework-bridge | 1.2.0   | 1.3.0   |
| masterminds/html5                    | 2.7.4   | 2.7.5   |
| symfony/console                      | v4.4.25 | v4.4.26 |
| symfony/dependency-injection         | v4.4.25 | v4.4.26 |
| symfony/error-handler                | v4.4.25 | v4.4.26 |
| symfony/http-foundation              | v4.4.25 | v4.4.26 |
| symfony/http-kernel                  | v4.4.25 | v4.4.26 |
| symfony/mime                         | v5.3.0  | v5.3.2  |
| symfony/process                      | v4.4.25 | v4.4.26 |
| symfony/serializer                   | v4.4.25 | v4.4.26 |
| symfony/translation                  | v4.4.25 | v4.4.26 |
| symfony/validator                    | v4.4.25 | v4.4.26 |
| symfony/var-dumper                   | v5.3.0  | v5.3.3  |
| symfony/yaml                         | v4.4.25 | v4.4.26 |
+--------------------------------------+---------+---------+

+------------------------------------+---------+---------+
| Dev Changes                        | From    | To      |
+------------------------------------+---------+---------+
| composer/ca-bundle                 | 1.2.9   | 1.2.10  |
| composer/composer                  | 2.1.0   | 2.1.3   |
| instaclick/php-webdriver           | 1.4.7   | 1.4.9   |
| mikey179/vfsstream                 | v1.6.8  | v1.6.9  |
| phpunit/phpunit                    | 8.5.15  | 8.5.17  |
| sirbrillig/phpcs-variable-analysis | v2.11.0 | v2.11.2 |
| symfony/filesystem                 | v4.4.25 | v4.4.26 |
| symfony/lock                       | v4.4.25 | v4.4.26 |
| symfony/phpunit-bridge             | v5.3.0  | v5.3.3  |
+------------------------------------+---------+---------+

Status: Needs review » Needs work

The last submitted patch, 2: 3224000.patch, failed testing. View results

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Needs work » Needs review
Parent issue: » #3220021: [meta] Ensure compatibility of Drupal 9 with PHP 8.1 (as it evolves)
StatusFileSize
new 1-4-interdiff.txt5.63 KB
new 3224000-4.patch47.41 KB

Fixing the test fails. They are due to a change in --no-scripts behaviour in 2.1.2 - see https://github.com/composer/composer/blob/master/CHANGELOG.md

Also two deps have new updates...

| phpunit/php-file-iterator          | 2.0.3   | 2.0.4   |
| phpunit/phpunit                    | 8.5.15  | 8.5.18  |

The full list:

+--------------------------------------+---------+---------+
| Production Changes                   | From    | To      |
+--------------------------------------+---------+---------+
| laminas/laminas-escaper              | 2.7.0   | 2.8.0   |
| laminas/laminas-stdlib               | 3.3.1   | 3.4.0   |
| laminas/laminas-zendframework-bridge | 1.2.0   | 1.3.0   |
| masterminds/html5                    | 2.7.4   | 2.7.5   |
| symfony/console                      | v4.4.25 | v4.4.26 |
| symfony/dependency-injection         | v4.4.25 | v4.4.26 |
| symfony/error-handler                | v4.4.25 | v4.4.26 |
| symfony/http-foundation              | v4.4.25 | v4.4.26 |
| symfony/http-kernel                  | v4.4.25 | v4.4.26 |
| symfony/mime                         | v5.3.0  | v5.3.2  |
| symfony/process                      | v4.4.25 | v4.4.26 |
| symfony/serializer                   | v4.4.25 | v4.4.26 |
| symfony/translation                  | v4.4.25 | v4.4.26 |
| symfony/validator                    | v4.4.25 | v4.4.26 |
| symfony/var-dumper                   | v5.3.0  | v5.3.3  |
| symfony/yaml                         | v4.4.25 | v4.4.26 |
+--------------------------------------+---------+---------+

+------------------------------------+---------+---------+
| Dev Changes                        | From    | To      |
+------------------------------------+---------+---------+
| composer/ca-bundle                 | 1.2.9   | 1.2.10  |
| composer/composer                  | 2.1.0   | 2.1.3   |
| instaclick/php-webdriver           | 1.4.7   | 1.4.9   |
| mikey179/vfsstream                 | v1.6.8  | v1.6.9  |
| phpunit/php-file-iterator          | 2.0.3   | 2.0.4   |
| phpunit/phpunit                    | 8.5.15  | 8.5.18  |
| sirbrillig/phpcs-variable-analysis | v2.11.0 | v2.11.2 |
| symfony/filesystem                 | v4.4.25 | v4.4.26 |
| symfony/lock                       | v4.4.25 | v4.4.26 |
| symfony/phpunit-bridge             | v5.3.0  | v5.3.3  |
+------------------------------------+---------+---------+
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Reviewed & tested by the community

The interdiff looks perfect to me, so RTBC.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new 3224000-6.patch50.96 KB

composer/composer, justinrainbow/json-schema and phar-io/manifest have all fixed PHP 8.1 compatibility issues in some more point releases.

composer-lock-diff-diff from #4:

 +--------------------------------------+---------+---------+
 | Production Changes                   | From    | To      |
 +--------------------------------------+---------+---------+
 | laminas/laminas-escaper              | 2.7.0   | 2.8.0   |
 | laminas/laminas-stdlib               | 3.3.1   | 3.4.0   |
 | laminas/laminas-zendframework-bridge | 1.2.0   | 1.3.0   |
 | masterminds/html5                    | 2.7.4   | 2.7.5   |
 | symfony/console                      | v4.4.25 | v4.4.26 |
 | symfony/dependency-injection         | v4.4.25 | v4.4.26 |
 | symfony/error-handler                | v4.4.25 | v4.4.26 |
 | symfony/http-foundation              | v4.4.25 | v4.4.26 |
 | symfony/http-kernel                  | v4.4.25 | v4.4.26 |
 | symfony/mime                         | v5.3.0  | v5.3.2  |
 | symfony/process                      | v4.4.25 | v4.4.26 |
 | symfony/serializer                   | v4.4.25 | v4.4.26 |
 | symfony/translation                  | v4.4.25 | v4.4.26 |
 | symfony/validator                    | v4.4.25 | v4.4.26 |
 | symfony/var-dumper                   | v5.3.0  | v5.3.3  |
 | symfony/yaml                         | v4.4.25 | v4.4.26 |
 +--------------------------------------+---------+---------+
 
 +------------------------------------+---------+---------+
 | Dev Changes                        | From    | To      |
 +------------------------------------+---------+---------+
 | composer/ca-bundle                 | 1.2.9   | 1.2.10  |
-| composer/composer                  | 2.1.0   | 2.1.3   |
+| composer/composer                  | 2.1.0   | 2.1.5   |
 | instaclick/php-webdriver           | 1.4.7   | 1.4.9   |
+| justinrainbow/json-schema          | 5.2.10  | 5.2.11  |
 | mikey179/vfsstream                 | v1.6.8  | v1.6.9  |
+| phar-io/manifest                   | 2.0.1   | 2.0.3   |
 | phpunit/php-file-iterator          | 2.0.3   | 2.0.4   |
 | phpunit/phpunit                    | 8.5.15  | 8.5.18  |
 | sirbrillig/phpcs-variable-analysis | v2.11.0 | v2.11.2 |
 | symfony/filesystem                 | v4.4.25 | v4.4.26 |
 | symfony/lock                       | v4.4.25 | v4.4.26 |
 | symfony/phpunit-bridge             | v5.3.0  | v5.3.3  |
 +------------------------------------+---------+---------+
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Needs review » Reviewed & tested by the community

Nice.

andypost’s picture

andypost
he/him
Primary language Russian
commented

https://github.com/symfony/symfony/releases/tag/v4.4.27

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
StatusFileSize
new 6-9-interdiff.txt47.99 KB
new 3224000-2-9.patch71.62 KB

Changes from #6

+------------------------------+---------+---------+
| Production Changes           | From    | To      |
+------------------------------+---------+---------+
| symfony/console              | v4.4.26 | v4.4.27 |
| symfony/debug                | v4.4.25 | v4.4.27 |
| symfony/dependency-injection | v4.4.26 | v4.4.27 |
| symfony/error-handler        | v4.4.26 | v4.4.27 |
| symfony/event-dispatcher     | v4.4.25 | v4.4.27 |
| symfony/http-foundation      | v4.4.26 | v4.4.27 |
| symfony/http-kernel          | v4.4.26 | v4.4.27 |
| symfony/mime                 | v5.3.2  | v5.3.4  |
| symfony/process              | v4.4.26 | v4.4.27 |
| symfony/routing              | v4.4.25 | v4.4.27 |
| symfony/serializer           | v4.4.26 | v4.4.27 |
| symfony/translation          | v4.4.26 | v4.4.27 |
| symfony/validator            | v4.4.26 | v4.4.27 |
| symfony/var-dumper           | v5.3.3  | v5.3.4  |
| symfony/yaml                 | v4.4.26 | v4.4.27 |
+------------------------------+---------+---------+

+---------------------------+---------+---------+
| Dev Changes               | From    | To      |
+---------------------------+---------+---------+
| phpunit/php-code-coverage | 7.0.14  | 7.0.15  |
| symfony/browser-kit       | v4.4.25 | v4.4.27 |
| symfony/css-selector      | v4.4.25 | v4.4.27 |
| symfony/dom-crawler       | v4.4.25 | v4.4.27 |
| symfony/filesystem        | v4.4.26 | v4.4.27 |
| symfony/finder            | v4.4.25 | v4.4.27 |
| symfony/lock              | v4.4.26 | v4.4.27 |
| symfony/phpunit-bridge    | v5.3.3  | v5.3.4  |
+---------------------------+---------+---------+
andypost’s picture

andypost
he/him
Primary language Russian
commented

And asap new releases https://github.com/symfony/symfony/releases/tag/v4.4.28

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
StatusFileSize
new 9-11-interdiff.txt2.37 KB
new 3224000-3-11.patch71.62 KB

Changes with new patch.

+---------------------+---------+---------+
| Production Changes  | From    | To      |
+---------------------+---------+---------+
| symfony/http-kernel | v4.4.27 | v4.4.28 |
+---------------------+---------+---------+
andypost’s picture

andypost
he/him
Primary language Russian
commented

I think 5.3.[3|4] packages also needs bump https://github.com/symfony/symfony/releases/tag/v5.3.5 something weird with SF releases

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

@andypost Symfony now only bumps the patch version number if the code actually changed in a package. Only symfony/http-kernel changed in 5.3.5 - for example there is no 5.3.1, 5.3.3 or 5.3.5 for symfony/mime: https://packagist.org/packages/symfony/mime

  • catch committed 71522f2 on 9.3.x 
    Issue #3224000 by alexpott, longwave, andypost: Update dependencies for...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed 71522f2 and pushed to 9.3.x. Thanks!

catch’s picture

catch
he/him
Primary language English
commented
Issue summary: View changes
Issue tags: +9.3.0 release notes
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Issue summary: View changes

Fixed release notes snippet with composer-lock-diff --from origin/9.2.x --no-links

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.