Problem/Motivation

This is spun off from #2966043: Handle oEmbed resources without an explicit height. Right now, the oEmbed field formatter has two settings, max_width and max_height, which are actually used as default values that take precedence over whatever the actual oEmbed resource says (if anything). This is somewhat misleading naming.

Steps to reproduce

N/A

Proposed resolution

Figure out if we should rename these and how. Should they be default_width and default_height? Something else?

Remaining tasks

If we decide to proceed, then write a patch with an update path.

User interface changes

None.

API changes

None.

Data model changes

TBD

Release notes snippet

TBD

Comments

phenaproxima created an issue. See original summary.

berdir’s picture

That doesn't sound like a fun update function to write, I would advice to not rename the keys ;) Probably not common, but you could add those in views for example. Maybe layout builder and who knows what else. Could just change the label, slightly confusing but that can be documented.

catch’s picture

If they take precedence, then are they really defaults? It'd be more like fixed width/height.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

imclean’s picture

max_width and max_height are currently used as fixed dimensions, which doesn't really follow the oEmbed spec. This is being addressed in #2966656: Negotiate max width/height of oEmbed assets more intelligently.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.