Active
Project:
Drupal core
Version:
main
Component:
media system
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
14 Jul 2021 at 12:28 UTC
Updated:
26 Sep 2022 at 01:37 UTC
Jump to comment: Most recent
This is spun off from #2966043: Handle oEmbed resources without an explicit height. Right now, the oEmbed field formatter has two settings, max_width and max_height, which are actually used as default values that take precedence over whatever the actual oEmbed resource says (if anything). This is somewhat misleading naming.
N/A
Figure out if we should rename these and how. Should they be default_width and default_height? Something else?
If we decide to proceed, then write a patch with an update path.
None.
None.
TBD
TBD
Comments
Comment #2
berdirThat doesn't sound like a fun update function to write, I would advice to not rename the keys ;) Probably not common, but you could add those in views for example. Maybe layout builder and who knows what else. Could just change the label, slightly confusing but that can be documented.
Comment #3
catchIf they take precedence, then are they really defaults? It'd be more like fixed width/height.
Comment #6
imclean commentedmax_width and max_height are currently used as fixed dimensions, which doesn't really follow the oEmbed spec. This is being addressed in #2966656: Negotiate max width/height of oEmbed assets more intelligently.