I noticed during the plugin changes I forgot to change these access checks and yet all tests remained green. Let's fix that and then backport the new tests to 8.x-1.x.

CommentFileSizeAuthor
#5 group-3223563-5.patch25.29 KBkristiaanvandeneynde
#2 group-3223563-2.patch19.32 KBkristiaanvandeneynde
#2 group-3223563-TEST-ONLY-FAIL.patch10.52 KBkristiaanvandeneynde

Comments

kristiaanvandeneynde created an issue. See original summary.

kristiaanvandeneynde’s picture

kristiaanvandeneynde
Primary language Dutch
Location Antwerp, Belgium
commented
Status: Active » Needs review
StatusFileSize
new group-3223563-TEST-ONLY-FAIL.patch10.52 KB
new group-3223563-2.patch19.32 KB

Maybe the access control handler changes need tests too. But not sure what those might look like.

The last submitted patch, 2: group-3223563-TEST-ONLY-FAIL.patch, failed testing. View results

kristiaanvandeneynde’s picture

kristiaanvandeneynde
Primary language Dutch
Location Antwerp, Belgium
commented

Okay, now let's add a simple unit test that checks that the access control handler calls the right plugin code, then backport the tests.

kristiaanvandeneynde’s picture

kristiaanvandeneynde
Primary language Dutch
Location Antwerp, Belgium
commented
StatusFileSize
new group-3223563-5.patch25.29 KB

This adds unit tests for GroupContentAccessControlHandler to make sure it calls the correct API internally. Will need to be changed when backported.

kristiaanvandeneynde’s picture

kristiaanvandeneynde
Primary language Dutch
Location Antwerp, Belgium
commented
Status: Needs review » Fixed

Creating follow-up issue for backporting tests.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.