Problem/Motivation

  • Get the number of entities related to K8s by REST API

Proposed resolution

  • Add a REST API to the cloud module to get the number of K8s entities

Issue fork cloud-3223525

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Ryo Yamashita created an issue. See original summary.

Ryo Yamashita opened merge request !321

ryo yamashita’s picture

ryo yamashita commented
Status: Needs work » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Issue summary: View changes

@ryo-yamashita

THank you for adding the REST API. It looks good, however please fix the coding standard violations: https://www.drupal.org/pift-ci-job/2127178

@baldwinlouie

The patch contains the spec change as follows:

BEFORE:

Drupal\cloud\Traits\ResourceBlockTrait

AFTER:

Drupal\cloud\Traits\CloudResourceTrait;

What do you think?

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work
baldwinlouie’s picture

baldwinlouie commented

@yas, @ryo-yamashita, Thank you for the patch. It looks good to me.

ryo yamashita’s picture

ryo yamashita commented
Status: Needs work » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@ryo-yamashita

Thank you for fixing the coding standard violations. I'll merge the patch to 4.x and close this issue as Fixed.

  • yas committed eb88701 on 4.x authored by Ryo Yamashita 
    Issue #3223525 by Ryo Yamashita, yas, baldwinlouie: Add a REST API to...

yas closed merge request !321

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.